shellcheck

Author: sebst

scripts/install.sh

@@ -1,7 +1,9 @@
 #!/usr/bin/env bash
 set -euo pipefail
+
 APP=feature-installer
 
+# Color definitions
 RED='\033[0;31m'
 GREEN='\033[0;32m'
 YELLOW='\033[1;33m'
@@ -10,33 +12,36 @@ NC='\033[0m' # No Color
 
 requested_version=${VERSION:-}
 
-os=$(uname -s | tr '[:upper:]' '[:upper:]')
+# Detect OS and architecture
+os=$(uname -s | tr '[:upper:]' '[:lower:]')
 if [[ "$os" == "darwin" ]]; then
     os="darwin"
+elif [[ "$os" == "linux" ]]; then
+    os="Linux"
 fi
-arch=$(uname -m)
 
+arch=$(uname -m)
 if [[ "$arch" == "aarch64" ]]; then
-  arch="arm64"
+    arch="arm64"
 elif [[ "$arch" == "x86_64" ]]; then
-  arch="x86_64"
+    arch="x86_64"
 fi
 
 filename="${APP}_${os}_${arch}.tar.gz"
+echo "$filename"
 
-echo $filename
-
-
+# Validate supported OS/architecture combinations
 case "$filename" in
     *"_Linux_"*)
         [[ "$arch" == "x86_64" || "$arch" == "arm64" ]] || exit 1
-    ;;
+        ;;
     *)
         echo -e "${RED}Unsupported OS/Arch: $os/$arch${NC}"
         exit 1
-    ;;
+        ;;
 esac
 
+# Print colored messages based on level
 print_message() {
     local level=$1
     local message=$2
@@ -61,11 +66,10 @@ else
 fi
 mkdir -p "$INSTALL_DIR"
 
+# Determine version and download URL
 if [ -z "$requested_version" ]; then
     url="https://github.com/devcontainer-community/feature-installer/releases/latest/download/$filename"
-    specific_version=$(curl -s https://api.github.com/repos/devcontainer-community/feature-installer/releases/latest | awk -F'"' '/"tag_name": "/ {gsub(/^v/, "", $4); print $4}')
-
-    if [[ $? -ne 0 || -z "$specific_version" ]]; then
+    if ! specific_version=$(curl -s https://api.github.com/repos/devcontainer-community/feature-installer/releases/latest | awk -F'"' '/"tag_name": "/ {gsub(/^v/, "", $4); print $4}') || [[ -z "$specific_version" ]]; then
         echo -e "${RED}Failed to fetch version information${NC}"
         exit 1
     fi
@@ -75,15 +79,13 @@ else
 fi
 
 
+# Check if feature-installer is already installed and compare versions
 check_version() {
     if command -v feature-installer >/dev/null 2>&1; then
-        feature_installer_path=$(which feature-installer)
-
-
         ## TODO: check if version is installed
         # installed_version=$(feature-installer version)
         installed_version="0.0.1"
-        installed_version=$(echo $installed_version | awk '{print $2}')
+        installed_version=$(echo "$installed_version" | awk '{print $2}')
 
         if [[ "$installed_version" != "$specific_version" ]]; then
             print_message info "Installed version: ${YELLOW}$installed_version."
@@ -94,10 +96,15 @@ check_version() {
     fi
 }
 
+# Download and install the feature-installer binary
 download_and_install() {
     print_message info "Downloading ${ORANGE}feature-installer ${GREEN}version: ${YELLOW}$specific_version ${GREEN}..."
     mkdir -p featureinstallertmp && cd featureinstallertmp
-    curl -# -L -o "$filename" "$url"
+    if ! curl -# -L -o "$filename" "$url"; then
+        print_message error "Failed to download $filename from $url"
+        cd .. && rm -rf featureinstallertmp
+        exit 1
+    fi
     tar -xzf "$filename"
     mv feature-installer "$INSTALL_DIR"
     cd .. && rm -rf featureinstallertmp
@@ -106,13 +113,14 @@ download_and_install() {
 check_version
 download_and_install
 
+# Add feature-installer directory to PATH in shell config files
 add_to_path() {
     local config_file=$1
     local command=$2
 
     if grep -Fxq "$command" "$config_file"; then
         print_message info "Command already exists in $config_file, skipping write."
-    elif [[ -w $config_file ]]; then
+    elif [[ -w "$config_file" ]]; then
         echo -e "\n# feature-installer" >> "$config_file"
         echo "$command" >> "$config_file"
         print_message info "Successfully added ${ORANGE}feature-installer ${GREEN}to \$PATH in $config_file"
@@ -151,14 +159,14 @@ if [[ $EUID -ne 0 ]]; then
 
     config_file=""
     for file in $config_files; do
-        if [[ -f $file ]]; then
-            config_file=$file
+        if [[ -f "$file" ]]; then
+            config_file="$file"
             break
         fi
     done
 
-    if [[ -z $config_file ]]; then
-        print_message error "No config file found for $current_shell. Checked files: ${config_files[@]}"
+    if [[ -z "$config_file" ]]; then
+        print_message error "No config file found for $current_shell. Checked files: ${config_files[*]}"
         exit 1
     fi
 
@@ -188,7 +196,7 @@ if [[ $EUID -ne 0 ]]; then
 fi
 
 if [ -n "${GITHUB_ACTIONS-}" ] && [ "${GITHUB_ACTIONS}" == "true" ]; then
-    echo "$INSTALL_DIR" >> $GITHUB_PATH
+    echo "$INSTALL_DIR" >> "$GITHUB_PATH"
     print_message info "Added $INSTALL_DIR to \$GITHUB_PATH"
 fi