Docker push fails with "no basic auth credentials" from runCmd

[elefantepequeno]

I'm attempting to build an image for deploy from within a devcontainer using devcontainers/ci@v0.3.1900000417 in GitHub Actions. Devcontainer image itself is built and pushed with no problems (previous step performs docker login), but my docker push command from runCmd fails with no basic auth credentials.

My workflow looks something like this:

...
jobs:
    deploy:
        ...
        steps:
            - name: Checkout Repository
              uses: actions/checkout@v4
              ...

            - name: Configure AWS Credentials
              uses: aws-actions/configure-aws-credentials@v4.2.1
              ...

            - name: Log in to Amazon ECR
              id: login-ecr
              uses: aws-actions/amazon-ecr-login@v2.0.1
              ...

            - name: Build images
              uses: devcontainers/ci@v0.3.1900000417
              env:
                  ECR_REGISTRY: ${{ steps.login-ecr.outputs.registry }}
              with:
                  imageName: ${{ env.ECR_REGISTRY }}/...  # <- this one is fine
                  cacheFrom: ${{ env.ECR_REGISTRY }}/...
                  push: always
                  runCmd: docker build --push ...  # <- this one is broken

[Kaniska244]

Hello @elefantepequeno ,

Thank you for reporting this issue. The thing here is that the runCmd is supposed to start the dev container and execute commands inside the dev container which has been built using devcontainers/ci@v0.3.1900000417 action. So I guess you would have to repeat the ECR login step manually inside the runCmd as the login you have done in earlier step has started the session in the GitHub action runner host/ VM.
But if you just want to push the dev container image to ECR, then you don't need that runCmd tag. You could perhaps add a following step with run tag and execute the docker push for the already built image.
Kindly let me know if more details are required or in case of any concern.

[elefantepequeno]

I want to build my production image inside the devcontainer, then deploy it. Pushing the devcontainer image is not an issue.

repeat the ECR login step manually

Is there a way to "proxy" docker authentication to devcontainer? I'm already using docker-in-docker feature.

[Kaniska244]

Hello @elefantepequeno ,

Hope you doing great. I don't see any option to fwd the logged in session from the host to the container directly.
Perhaps you could try aws ecr get-login-passwrd option if not using already which could get you a temporary authentication token which you could fwd to the container from the host to the container with either env tag in devcontainers/ci action if using runCmd or with -e option if using docker run to start the container.
Kindly let me now in case of further concern.

[Kaniska244]

Closing this issue presuming the issue has been fixed for the user. Kindly reopen the issue if the problem still persists.