Skip to content

Commit a22ba59

Browse files
committed
Do not use build contexts with Podman and Compose (microsoft/vscode-remote-release#10178)
1 parent e0598db commit a22ba59

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

src/spec-node/containerFeatures.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -232,7 +232,9 @@ async function getFeaturesBuildOptions(params: DockerResolverParameters, devCont
232232
// TODO generate an image name that is specific to this dev container?
233233
const buildKitVersionParsed = params.buildKitVersion?.versionMatch ? parseVersion(params.buildKitVersion.versionMatch) : undefined;
234234
const minRequiredVersion = [0, 8, 0];
235-
const useBuildKitBuildContexts = buildKitVersionParsed ? !isEarlierVersion(buildKitVersionParsed, minRequiredVersion) : false;
235+
const useBuildKitBuildContexts = params.isPodman
236+
? !('dockerComposeFile' in devContainerConfig.config) // https://github.com/microsoft/vscode-remote-release/issues/10178#issuecomment-2330257443
237+
: buildKitVersionParsed ? !isEarlierVersion(buildKitVersionParsed, minRequiredVersion) : false;
236238
const buildContentImageName = 'dev_container_feature_content_temp';
237239
const isBuildah = !!params.buildKitVersion?.versionString.toLowerCase().includes('buildah');
238240

0 commit comments

Comments
 (0)