[Updates] Automated vendor dotnet-install script #1236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I figured out the tests here are failing because the fix here also requires some changes to the tests that were made in other PRs: https://github.com/devcontainers/features/pull/1230/files#diff-0c7ceeb357dce5a814a4684b887f7ebc68e17312b3720646ccc00d4522bd56bb Basically the tests as they stand hardcode the "latest" version of dotnet is 8.0 and in the other PR they just removed running a test project if there is no version specified for dotnet in the feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Updates] Automated vendor dotnet-install script