Skip to content

Commit dd7aabf

Browse files
Supports javascript-node 22 (#1044)
* Support javascript-node 20 * update eslintrc.json to eslint.config.js
1 parent 7cb5857 commit dd7aabf

File tree

5 files changed

+33
-31
lines changed

5 files changed

+33
-31
lines changed

src/javascript-node/.devcontainer/Dockerfile

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
# [Choice] Node.js version (use -bookworm, and -bullseye variants on local arm64/Apple Silicon): 20, 18, 20-bookworm, 18-bookworm, 20-bullseye, 18-bullseye, 20-buster, 18-buster
2-
ARG VARIANT=20-bookworm
1+
ARG VARIANT=22-bookworm
32
FROM node:${VARIANT}
43

54
ARG USERNAME=node

src/javascript-node/README.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
| *Categories* | Core, Languages |
1010
| *Image type* | Dockerfile |
1111
| *Published image* | mcr.microsoft.com/devcontainers/javascript-node |
12-
| *Available image variants* | 20 / 20-bookworm, 18 / 18-bookworm, 20-bullseye, 18-bullseye, 20-buster, 18-buster ([full list](https://mcr.microsoft.com/v2/devcontainers/javascript-node/tags/list)) |
12+
| *Available image variants* | 22 / 22-bookworm, 20 / 20-bookworm, 18 / 18-bookworm, 20-bullseye, 18-bullseye, 20-buster, 18-buster ([full list](https://mcr.microsoft.com/v2/devcontainers/javascript-node/tags/list)) |
1313
| *Published image architecture(s)* | x86-64, arm64/aarch64 for `bookworm`, and `bullseye` variants |
1414
| *Container host OS support* | Linux, macOS, Windows |
1515
| *Container OS* | Debian |
@@ -20,16 +20,17 @@
2020
You can directly reference pre-built versions of `Dockerfile` by using the `image` property in `.devcontainer/devcontainer.json` or updating the `FROM` statement in your own `Dockerfile` to one of the following. An example `Dockerfile` is included in this repository.
2121

2222
- `mcr.microsoft.com/devcontainers/javascript-node` (latest)
23+
- `mcr.microsoft.com/devcontainers/javascript-node:22` (or `22-bookworm`, `22-bullseye` to pin to an OS version)
2324
- `mcr.microsoft.com/devcontainers/javascript-node:20` (or `20-bookworm`, `20-bullseye`, `20-buster` to pin to an OS version)
2425
- `mcr.microsoft.com/devcontainers/javascript-node:18` (or `18-bookworm`, `18-bullseye`, `18-buster` to pin to an OS version)
2526

2627
Refer to [this guide](https://containers.dev/guide/dockerfile) for more details.
2728

2829
You can decide how often you want updates by referencing a [semantic version](https://semver.org/) of each image. For example:
2930

30-
- `mcr.microsoft.com/devcontainers/typescript-node:1-20` (or `1-20-bookworm`, `1-20-bullseye`, `1-20-buster`)
31-
- `mcr.microsoft.com/devcontainers/typescript-node:1.0-20` (or `1.0-20-bookworm`, `1.0-20-bullseye`, `1.0-20-buster`)
32-
- `mcr.microsoft.com/devcontainers/typescript-node:1.0.3-20` (or `1.0.3-20-bookworm`, `1.0.3-20-bullseye`, `1.0.3-20-buster`)
31+
- `mcr.microsoft.com/devcontainers/typescript-node:1-22` (or `1-22-bookworm`, `1-22-bullseye`)
32+
- `mcr.microsoft.com/devcontainers/typescript-node:1.1-22` (or `1.1-22-bookworm`, `1.1-22-bullseye`)
33+
- `mcr.microsoft.com/devcontainers/typescript-node:1.1.0-22` (or `1.1.0-22-bookworm`, `1.1.0-22-bullseye`)
3334

3435
However, we only do security patching on the latest [non-breaking, in support](https://github.com/devcontainers/images/issues/90) versions of images (e.g. `1-1.0`). You may want to run `apt-get update && apt-get upgrade` in your Dockerfile if you lock to a more specific version to at least pick up OS security updates.
3536

src/javascript-node/manifest.json

Lines changed: 17 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,23 @@
11
{
22
"version": "1.0.11",
33
"variants": [
4+
"22-bookworm",
45
"20-bookworm",
56
"18-bookworm",
7+
"22-bullseye",
68
"20-bullseye",
79
"18-bullseye",
810
"20-buster",
911
"18-buster"
1012
],
1113
"build": {
12-
"latest": "20-bookworm",
14+
"latest": "22-bookworm",
1315
"rootDistro": "debian",
1416
"architectures": {
17+
"22-bookworm": [
18+
"linux/amd64",
19+
"linux/arm64"
20+
],
1521
"20-bookworm": [
1622
"linux/amd64",
1723
"linux/arm64"
@@ -20,6 +26,10 @@
2026
"linux/amd64",
2127
"linux/arm64"
2228
],
29+
"22-bullseye": [
30+
"linux/amd64",
31+
"linux/arm64"
32+
],
2333
"20-bullseye": [
2434
"linux/amd64",
2535
"linux/arm64"
@@ -39,14 +49,17 @@
3949
"javascript-node:${VERSION}-${VARIANT}"
4050
],
4151
"variantTags": {
42-
"20-bookworm": [
43-
"javascript-node:${VERSION}-20",
52+
"22-bookworm": [
53+
"javascript-node:${VERSION}-22",
4454
"javascript-node:${VERSION}-bookworm"
4555
],
56+
"20-bookworm": [
57+
"javascript-node:${VERSION}-20"
58+
],
4659
"18-bookworm": [
4760
"javascript-node:${VERSION}-18"
4861
],
49-
"20-bullseye": [
62+
"22-bullseye": [
5063
"javascript-node:${VERSION}-bullseye"
5164
],
5265
"20-buster": [

src/javascript-node/test-project/.eslintrc.json

Lines changed: 0 additions & 21 deletions
This file was deleted.
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
module.exports = {
2+
"rules": {
3+
"no-console": 0,
4+
"eqeqeq":"warn",
5+
"no-cond-assign": 0,
6+
"no-unused-vars": 1,
7+
"no-extra-semi": "warn",
8+
"semi": "warn"
9+
}
10+
};

0 commit comments

Comments
 (0)