Skip to content

Commit e9ed650

Browse files
committed
Implementing review comments.
1 parent e17a9fd commit e9ed650

File tree

3 files changed

+8
-3
lines changed

3 files changed

+8
-3
lines changed

src/universal/.devcontainer/local-features/patch-conda/install.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ sudo_if /opt/conda/bin/python3 -m pip install --upgrade pip
5151
# Temporary: Upgrade python packages due to security vulnerabilities
5252
# They are installed by the conda feature and Conda distribution does not have the patches.
5353

54-
# https://github.com/advisories/GHSA-h4gh-qq45-vh27
54+
# https://github.com/advisories/GHSA-79v4-65xg-pq4g
5555
update_python_package /opt/conda/bin/python3 cryptography "44.0.1"
5656

5757
update_conda_package pyopenssl "25.0.0"

src/universal/.devcontainer/local-features/patch-python/install.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,9 @@ update_package() {
3838
sudo_if "$PYTHON_PATH -m pip install --upgrade --no-cache-dir $PACKAGE==$VERSION"
3939
sudo_if "$PYTHON_PATH -m pip show --no-python-version-warning $PACKAGE"
4040
}
41-
41+
# Updating pip version for python 3.11. Must be removed when pinned version 3.11 is updated to a different python version.
4242
sudo_if /usr/local/python/3.11.*/bin/python -m pip install --upgrade pip
4343

4444
# https://github.com/advisories/GHSA-5rjg-fvgr-3xxf
45+
# Updating setuptools version for python 3.11. Must be removed when pinned version 3.11 is updated to a different python version.
4546
update_package /usr/local/python/3.11.*/bin/python setuptools "78.1.1"

src/universal/test-project/test.sh

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -178,9 +178,13 @@ check "java-version-on-path-is-12.0.2" java --version | grep 12.0.2
178178
ls -la /home/codespace
179179

180180
## Python - current
181-
checkPythonPackageVersion "/usr/local/python/3.11.*/bin/python" "setuptools" "78.1.1"
181+
checkPythonPackageVersion "python" "setuptools" "78.1.1"
182182
checkPythonPackageVersion "python" "requests" "2.31.0"
183183

184+
## Python -alternative version 3.11. Must be removed when pinned version 3.11 is updated to a different python version.
185+
checkPythonPackageVersion "/usr/local/python/3.11.*/bin/python" "setuptools" "78.1.1"
186+
check "pip-version-for-3.11" bash -c "/usr/local/python/3.11.*/bin/python -m pip --version | grep 25.3"
187+
184188
## Conda Python
185189
checkCondaPackageVersion "requests" "2.31.0"
186190
checkCondaPackageVersion "cryptography" "44.0.1"

0 commit comments

Comments
 (0)