Skip to content

Commit d16960b

Browse files
refactor(editor): Extract large chunks from NodeSettings (#17665)
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
1 parent b64c8ad commit d16960b

File tree

6 files changed

+367
-350
lines changed

6 files changed

+367
-350
lines changed

packages/frontend/editor-ui/src/components/NodeDetailsView.vue

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@ const emit = defineEmits<{
4949
connectionType: NodeConnectionType,
5050
connectionIndex?: number,
5151
];
52-
redrawNode: [nodeName: string];
5352
stopExecution: [];
5453
}>();
5554
@@ -81,7 +80,6 @@ const message = useMessage();
8180
const { APP_Z_INDEXES } = useStyles();
8281
8382
const settingsEventBus = createEventBus();
84-
const redrawRequired = ref(false);
8583
const runInputIndex = ref(-1);
8684
const runOutputIndex = computed(() => ndvStore.output.run ?? -1);
8785
const selectedInput = ref<string | undefined>();
@@ -498,18 +496,6 @@ const close = async () => {
498496
return;
499497
}
500498
501-
if (
502-
activeNode.value &&
503-
(typeof activeNodeType.value?.outputs === 'string' ||
504-
typeof activeNodeType.value?.inputs === 'string' ||
505-
redrawRequired.value)
506-
) {
507-
const nodeName = activeNode.value.name;
508-
setTimeout(() => {
509-
emit('redrawNode', nodeName);
510-
}, 1);
511-
}
512-
513499
if (outputPanelEditMode.value.enabled && activeNode.value) {
514500
const shouldPinDataBeforeClosing = await message.confirm(
515501
'',
@@ -842,7 +828,6 @@ onBeforeUnmount(() => {
842828
@value-changed="valueChanged"
843829
@execute="onNodeExecute"
844830
@stop-execution="onStopExecution"
845-
@redraw-required="redrawRequired = true"
846831
@activate="onWorkflowActivate"
847832
@switch-selected-node="onSwitchSelectedNode"
848833
@open-connection-node-creator="onOpenConnectionNodeCreator"

packages/frontend/editor-ui/src/components/NodeDetailsViewV2.vue

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,6 @@ const message = useMessage();
8585
const { APP_Z_INDEXES } = useStyles();
8686
8787
const settingsEventBus = createEventBus();
88-
const redrawRequired = ref(false);
8988
const runInputIndex = ref(-1);
9089
const runOutputIndex = ref(-1);
9190
const isLinkingEnabled = ref(true);
@@ -821,7 +820,6 @@ onBeforeUnmount(() => {
821820
:class="$style.settings"
822821
@execute="onNodeExecute"
823822
@stop-execution="onStopExecution"
824-
@redraw-required="redrawRequired = true"
825823
@activate="onWorkflowActivate"
826824
@switch-selected-node="onSwitchSelectedNode"
827825
@open-connection-node-creator="onOpenConnectionNodeCreator"

0 commit comments

Comments
 (0)