Update Date-Picker Screen Code #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @kadubhumika 👋 You still have multiple similar issues mentioned in the previous PR. Here are some of them:
Thank you so much for your contributions; we appreciate your efforts. However, to scale and maintain the library effectively, we need to follow best practices. Please review the list of issues provided in PR: #1. Additionally, reviewing and testing the code may take some time. External factors could also lead to delays, so please be patient. We also ask that you avoid frequent comments on PRs and issues. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the Date Picker files according to your suggestions and requirements. Please review the code and the UI styling; if you feel any improvements are needed, kindly share your feedback.
Actually, I faced some issues running the app and using the preview system, so I created a new Android project to implement and debug the Date Picker screen. After successfully building the UI and testing it there, I integrated the working code into the main file. This approach helped me ensure the demo runs smoothly.
I have also shared a video for your reference. Please check it and let me know your thoughts. I really enjoyed working on this project and found it very educational.
If you like it, please feel free to merge the changes.
WhatsApp.Video.2025-10-22.at.14.02.04_20b43084.mp4