Skip to content

Also buffer IFD reads #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
feefladder wants to merge 13 commits into from
Closed

Also buffer IFD reads #77

feefladder wants to merge 13 commits into from

Conversation

@feefladder
Copy link
Contributor

@feefladder feefladder commented Mar 23, 2025

Builds on #76, but also computes ifd size beforehand and fetches all of it. Only really beneficial for non-cogs.

The same:

  • calculate IFD size = ifd_entry_byte_count * tag_count
  • load into EndianAwareReader
  • read the rest of the IFD using the EndianAwareReader

@feefladder feefladder mentioned this pull request Mar 23, 2025
Closed
@kylebarron
Copy link
Member

kylebarron commented Mar 24, 2025

If this builds on #76 we can come back to discuss this after we resolve #76 and #78

@feefladder
Copy link
Contributor Author

feefladder commented Mar 25, 2025

Also, this was just a thought I had. We can also close it, because it's mostly only useful for non-cog tiffs that have their IFDs not in the prefetch range, which could well be solved by a simple buffering reader. (I sense some resistance to #76, but that one is more important)

@feefladder feefladder closed this Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@feefladder @kylebarron