fix: reject items without a collection ID (#133)

Author: hrodmn

lib/ingestor-api/runtime/src/schemas.py

@@ -43,6 +43,7 @@ def is_accessible(cls, href):
 
 class AccessibleItem(Item):
     assets: Dict[str, AccessibleAsset]
+    collection: str  # override because default is str | None
 
     @field_validator("collection")
     def exists(cls, collection):

lib/ingestor-api/runtime/tests/test_registration.py

@@ -97,6 +97,19 @@ def test_validates_missing_collection(
             len(self.db.fetch_many(status="queued")["items"]) == 0
         ), "data should not be stored in DB"
 
+    def test_validates_no_collection_id(self, asset_exists):
+        item_sans_id = self.example_ingestion.item.model_copy()
+        item_sans_id.collection = None
+
+        response = self.api_client.post(
+            ingestion_endpoint,
+            json=item_sans_id.model_dump(mode="json"),
+        )
+        assert response.status_code == 422, "should get validation error"
+        assert (
+            len(self.db.fetch_many(status="queued")["items"]) == 0
+        ), "data should not be stored in DB"
+
     def test_validates_missing_assets(
         self, client_authenticated, collection_exists, asset_missing
     ):