Enhance STAC API tests to verify base path for landing page, collections, and item links with custom ingress paths

Author: emmanuelmathot

.github/workflows/tests/test_stac.py

@@ -14,6 +14,15 @@ def test_stac_api(stac_endpoint):
     # Ping
     assert client.get(f"{stac_endpoint}/_mgmt/ping").status_code == 200
 
+    # Landing page
+    resp = client.get(stac_endpoint)
+    assert resp.status_code == 200
+    landing = resp.json()
+    # Verify landing page links have correct base path
+    for link in landing["links"]:
+        if link["href"].startswith("/"):
+            assert link["href"].startswith(stac_endpoint.split("://")[1])
+
     # viewer
     #assert client.get(f"{stac_endpoint}/index.html").status_code == 200
     assert client.get(f"{stac_endpoint}/index.html").status_code == 404
@@ -26,11 +35,21 @@ def test_stac_api(stac_endpoint):
     ids = [c["id"] for c in collections]
     assert "noaa-emergency-response" in ids
 
+    # Verify collection links have correct base path
+    for collection in collections:
+        for link in collection["links"]:
+            if link["href"].startswith("/"):
+                assert link["href"].startswith(stac_endpoint.split("://")[1])
+
     # items
     resp = client.get(f"{stac_endpoint}/collections/noaa-emergency-response/items")
     assert resp.status_code == 200
-    items = resp.json()["features"]
-    assert len(items) == 10
+    items = resp.json()
+    # Verify item links have correct base path
+    for feature in items["features"]:
+        for link in feature["links"]:
+            if link["href"].startswith("/"):
+                assert link["href"].startswith(stac_endpoint.split("://")[1])
 
     # item
     resp = client.get(
@@ -51,6 +70,45 @@ def test_stac_to_raster(stac_endpoint):
     #assert resp.status_code == 307
     assert resp.status_code == 404
 
+def test_stac_custom_path(stac_endpoint):
+    """test stac with custom ingress path."""
+    # If we're using a custom path (e.g., /api instead of /stac)
+    base_path = stac_endpoint.split("://")[1]
+    
+    # Landing page
+    resp = client.get(stac_endpoint)
+    assert resp.status_code == 200
+    landing = resp.json()
+    
+    # All links should use the custom path
+    for link in landing["links"]:
+        if link["href"].startswith("/"):
+            assert link["href"].startswith(base_path), \
+                f"Link {link['href']} doesn't start with {base_path}"
+
+    # Collections should also use the custom path
+    resp = client.get(f"{stac_endpoint}/collections")
+    assert resp.status_code == 200
+    collections = resp.json()["collections"]
+    
+    for collection in collections:
+        for link in collection["links"]:
+            if link["href"].startswith("/"):
+                assert link["href"].startswith(base_path), \
+                    f"Collection link {link['href']} doesn't start with {base_path}"
+
+    # Test a specific item
+    resp = client.get(f"{stac_endpoint}/collections/noaa-emergency-response/items")
+    assert resp.status_code == 200
+    items = resp.json()
+    
+    # Item links should also use the custom path
+    for feature in items["features"]:
+        for link in feature["links"]:
+            if link["href"].startswith("/"):
+                assert link["href"].startswith(base_path), \
+                    f"Item link {link['href']} doesn't start with {base_path}"
+
     # viewer
     resp = client.get(
         f"{stac_endpoint}/collections/noaa-emergency-response/items/20200307aC0853300w361200/viewer",