Skip to content

Commit 87b3719

Browse files
author
ranchodeluxe
committed
change release docs
1 parent 08fcd5a commit 87b3719

File tree

3 files changed

+9
-228
lines changed

3 files changed

+9
-228
lines changed

.github/pre-release.yml

Lines changed: 0 additions & 169 deletions
This file was deleted.

.github/workflows/release.yml

Lines changed: 1 addition & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ env:
1010

1111
jobs:
1212
release:
13-
if: "!startsWith(github.ref, 'refs/tags/eoapi-')"
13+
if: "!startsWith(github.ref, 'refs/tags/eoapi-')" # prevent the helm chart releaser from running this release workflow
1414
runs-on: ubuntu-latest
1515
steps:
1616
- uses: actions/checkout@v4
@@ -25,17 +25,6 @@ jobs:
2525
- uses: azure/setup-helm@v4
2626
with:
2727
version: ${{ env.HELM_VERSION }}
28-
#token: ${{ secrets.GITHUB_TOKEN }}
29-
30-
# - name: update gh-pages with content from main
31-
# env:
32-
# GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
33-
# run: |
34-
# git checkout main
35-
# git pull origin main
36-
# git checkout gh-pages
37-
# git pull origin gh-pages
38-
# git merge -X theirs main
3928

4029
- name: add helm repos
4130
run: |
@@ -52,28 +41,3 @@ jobs:
5241
CR_TOKEN: "${{ secrets.GITHUB_TOKEN }}"
5342
CR_SKIP_EXISTING: true
5443
CR_INDEX_PATH: "."
55-
56-
57-
# - name: helm release packages
58-
# env:
59-
# CR_TOKEN: ${{ secrets.GITHUB_TOKEN }}
60-
# run: |
61-
# # update `values.yaml` with a gitSha
62-
# chart="helm-chart/eoapi"
63-
# COMMITSHA=$(git rev-parse HEAD | cut -c1-10)
64-
# sed -i "s|gitSha: \"[a-zA-Z0-9]+\"|gitSha: \"$COMMITSHA\"|g" "$chart"/values.yaml
65-
#
66-
# # package recent chart
67-
# helm package $chart --destination .
68-
#
69-
# # create the index file
70-
# helm repo index .
71-
#
72-
# git add -A
73-
# chart_version=$(cat $chart/Chart.yaml| grep version: | cut -d' ' -f2)
74-
# git commit -m $chart_version
75-
# git push origin gh-pages
76-
77-
78-
79-

docs/release.md

Lines changed: 8 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,16 @@
11
### Release Workflow
22

3-
1. PRs that include changes in the `helm-chart/` directory with a base of `main` should also choose a PR
4-
title that decides if the chart's version bumps will be major, minor or patch according to semantic versioning.
5-
All they need to do is prefix `major: `, `minor: ` or `patch: ` to the PR title
3+
1. PRs that include changes in the `helm-chart/<eoapi> || <eoapi-support>` charts are manually required to consider
4+
whether their changes are major, minor or patch (in terms of semantic versioning) and bump the appropriate
5+
chart `version: ` (which follows semver) and `appVersion: ` (which does not follow semver) for each affected chart
66

7+
3. The releaser then merges the above PR
78

8-
2. All PRs opened, synchronized or reopened against `main` will kick off a "pre-release" workflow that does the following:
9-
10-
1. detect if there are changes in the `helm-chart/` directory (if no changes are detected the "pre-release.yaml" workflow exits gracefully)
11-
12-
2. sniff the PR title to determine major, minor or patch bumps
13-
14-
3. increment the helm chart's `version` and `appVersion` accordingly
15-
16-
4. add a commit to the open PR with the `Chart.yaml` bumps and a commit titled: `'release version to v<version-increment>`
17-
18-
19-
3. The releaser should review this PR and make sure everything (include the `Chart.yaml` bumps seem correct). Then merge the PR
20-
21-
22-
3. Then the releaser should go to the Github release UI/UX and kick off a new release by doing the following:
9+
4. Then the releaser should go to the Github release UI/UX and kick off a new release by doing the following:
2310

2411
1. click "Draft New Release"
2512

26-
2. create a new tag for the branch `main` with the chart version listed in the previous PR's commit message
13+
2. create a new tag for that matches the `helm-chart/eoapi/Chart.yaml:version` they just commited
2714

2815
3. click the "Generate release notes"
2916

@@ -32,8 +19,7 @@ All they need to do is prefix `major: `, `minor: ` or `patch: ` to the PR title
3219
5. click the "Publish release"
3320

3421

35-
5. This last step then kicks off another GH Actions workflow called "release.yaml" which publishes the helm chart to the
36-
`gh-pages` branch
37-
22+
5. This last step then kicks off another GH Actions workflow called "release.yaml" which publishes any helm charts
23+
that had version bumps since the last time
3824

3925
6. Verify the release is all good by running `helm repo update && helm search repo eoapi --versions`

0 commit comments

Comments
 (0)