feat: Add observability tests #342
Merged
+1,220
−203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pantierra
changed the title
pantierra
force-pushed
the
feature/observatbility-tests
branch
from
03b9fa4 to
260db40
Compare
pantierra
force-pushed
the
feature/observatbility-tests
branch
10 times, most recently
from
6cef91a to
1be9a90
Compare
pantierra
force-pushed
the
feature/observatbility-tests
branch
7 times, most recently
from
64ce185 to
c6bbc7b
Compare
pantierra
force-pushed
the
feature/observatbility-tests
branch
4 times, most recently
from
9015a5a to
c1f81e9
Compare
pantierra
force-pushed
the
feature/observatbility-tests
branch
3 times, most recently
from
cb46b35 to
5d94887
Compare
pantierra
force-pushed
the
feature/observatbility-tests
branch
2 times, most recently
from
2e47d81 to
3f28185
Compare
ciaransweet
requested changes
Nov 14, 2025
| import pytest | ||
| import requests | ||
|
|
||
| # Import shared utilities from conftest |
Contributor
Author
There was a problem hiding this comment.
I think we need them.
A few of them are regular functions we have to import anyway (like kubectl_get and get_pod_metrics ), so I also decided to use functions (not fixtures) for these simple environment variable readers that don't need any setup/teardown.
Removed the fixtures all together, but left the functions import.
Contributor
There was a problem hiding this comment.
Ah, I just meant the comment :D
pantierra
force-pushed
the
feature/observatbility-tests
branch
from
3f28185 to
6fd20b2
Compare
Contributor
Author
|
Many thanks for your review(s), @ciaransweet! ❤️ |
pantierra
force-pushed
the
feature/observatbility-tests
branch
from
6fd20b2 to
567a1f3
Compare
ciaransweet
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tests for the observability stack (fromer
eoapi-support).