Merge pull request #114 from moradology/feature/validate-bbox

Add validation for bounding boxes

Author: vincentsarago

CHANGELOG.md

@@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 ### Added
 
+- Validate order of bounding box values. (author @moradology, https://github.com/developmentseed/geojson-pydantic/pull/114)
 - Enforce required keys and avoid defaults. This aim to follow the geojson specification to the letter.
 
     ```python

geojson_pydantic/features.py

@@ -27,6 +27,23 @@ class Config:
 
         use_enum_values = True
 
+    @validator("bbox", pre=True)
+    def check_bbox(cls, bbox: BBox) -> BBox:
+        """Check that bbox is valid."""
+        if len(bbox) == 6:
+            if bbox[0] > bbox[3] or bbox[1] > bbox[4] or bbox[2] > bbox[5]:  # type: ignore
+                raise ValueError(
+                    "BBox must be in the form [west, south, bottom, east, north, top]"
+                )
+        elif len(bbox) == 4:
+            if bbox[0] > bbox[2] or bbox[1] > bbox[3]:
+                raise ValueError("BBox must be in the form [west, south, east, north]")
+        else:
+            raise ValueError(
+                "BBox must be in the form [west, south, east, north] or [west, south, bottom, east, north, top]"
+            )
+        return bbox
+
     @validator("geometry", pre=True, always=True)
     def set_geometry(cls, geometry: Any) -> Any:
         """set geometry from geo interface or input"""

tests/test_features.py

@@ -229,3 +229,11 @@ def test_feature_validation():
     with pytest.raises(ValidationError):
         # missing geometry
         Feature(type="Feature", properties=None)
+
+    with pytest.raises(ValidationError):
+        # bad bbox2d
+        Feature(type="Feature", properties=None, bbox=[100, 100, 0, 0])
+
+    with pytest.raises(ValidationError):
+        # bad bbox3d
+        Feature(type="Feature", properties=None, bbox=[100, 100, 100, 0, 0, 0])