chore: Support Clippy 1.88 (#497)

* chore: Support Clippy 1.88

* More lint fixes

Author: kylebarron

obstore/build.rs

@@ -8,7 +8,7 @@ fn main() {
     let lockfile_location = get_lockfile_location().unwrap();
     let (version, source) = read_lockfile(&lockfile_location);
 
-    println!("cargo:rustc-env=OBJECT_STORE_VERSION={}", version);
+    println!("cargo:rustc-env=OBJECT_STORE_VERSION={version}");
     println!(
         "cargo:rustc-env=OBJECT_STORE_SOURCE={}",
         source.map(|s| s.to_string()).unwrap_or("".to_string())

obstore/src/attributes.rs

@@ -32,7 +32,7 @@ fn attribute_to_string(attribute: &Attribute) -> Cow<'static, str> {
         Attribute::ContentType => Cow::Borrowed("Content-Type"),
         Attribute::CacheControl => Cow::Borrowed("Cache-Control"),
         Attribute::Metadata(x) => x.clone(),
-        other => panic!("Unexpected attribute: {:?}", other),
+        other => panic!("Unexpected attribute: {other:?}"),
     }
 }
 

obstore/src/buffered.rs

@@ -152,8 +152,7 @@ impl PyReadableFile {
             2 => SeekFrom::End(offset as _),
             other => {
                 return Err(PyIOError::new_err(format!(
-                    "Invalid value for whence in seek: {}",
-                    other
+                    "Invalid value for whence in seek: {other}"
                 )))
             }
         };

obstore/src/list.rs

@@ -415,7 +415,7 @@ pub(crate) fn list(
             "\nInstall with `pip install arro3-core`."
         );
         py.import(intern!(py, "arro3.core"))
-            .map_err(|err| PyImportError::new_err(format!("{}\n\n{}", msg, err)))?;
+            .map_err(|err| PyImportError::new_err(format!("{msg}\n\n{err}")))?;
     }
 
     let store = store.into_inner().clone();

obstore/src/put.rs

@@ -34,8 +34,7 @@ impl<'py> FromPyObject<'py> for PyPutMode {
                 "create" => Ok(Self(PutMode::Create)),
                 "overwrite" => Ok(Self(PutMode::Overwrite)),
                 _ => Err(PyValueError::new_err(format!(
-                    "Unexpected input for PutMode: {}",
-                    s
+                    "Unexpected input for PutMode: {s}"
                 ))),
             }
         } else {

obstore/src/signer.rs

@@ -129,8 +129,7 @@ impl<'py> FromPyObject<'py> for PyMethod {
             "CONNECT" => Method::CONNECT,
             other => {
                 return Err(PyValueError::new_err(format!(
-                    "Unsupported HTTP method {}",
-                    other
+                    "Unsupported HTTP method {other}"
                 )))
             }
         };

pyo3-object_store/src/api.rs

@@ -44,7 +44,7 @@ pub fn register_store_module(
     parent_module_str: &str,
     sub_module_str: &str,
 ) -> PyResult<()> {
-    let full_module_string = format!("{}.{}", parent_module_str, sub_module_str);
+    let full_module_string = format!("{parent_module_str}.{sub_module_str}");
 
     let child_module = PyModule::new(parent_module.py(), sub_module_str)?;
 
@@ -102,7 +102,7 @@ pub fn register_exceptions_module(
     parent_module_str: &str,
     sub_module_str: &str,
 ) -> PyResult<()> {
-    let full_module_string = format!("{}.{}", parent_module_str, sub_module_str);
+    let full_module_string = format!("{parent_module_str}.{sub_module_str}");
 
     let child_module = PyModule::new(parent_module.py(), sub_module_str)?;
 

pyo3-object_store/src/aws/store.rs

@@ -192,7 +192,7 @@ impl PyS3Store {
                 prefix.as_ref()
             )
         } else {
-            format!("S3Store(bucket=\"{}\")", bucket)
+            format!("S3Store(bucket=\"{bucket}\")")
         }
     }
 

pyo3-object_store/src/azure/store.rs

@@ -213,8 +213,7 @@ impl PyAzureStore {
             )
         } else {
             format!(
-                "AzureStore(container_name=\"{}\", account_name=\"{}\")",
-                container_name, account_name,
+                "AzureStore(container_name=\"{container_name}\", account_name=\"{account_name}\")"
             )
         }
     }

pyo3-object_store/src/client.rs

@@ -65,7 +65,7 @@ impl<'py> FromPyObject<'py> for PyClientOptions {
                 if &key == "default_headers" {
                     default_headers = Some(value.extract::<PyHeaderMap>()?);
                 } else {
-                    return Err(PyValueError::new_err(format!("Invalid key: {}.", key)));
+                    return Err(PyValueError::new_err(format!("Invalid key: {key}.")));
                 }
             }
         }