Refactor repetitive code

Author: kamicut

app/tests/permissions/add-org-team.test.js

@@ -1,58 +1,32 @@
 const test = require('ava')
 const db = require('../../db')
 const path = require('path')
-const hydra = require('../../lib/hydra')
-const sinon = require('sinon')
+const { initializeContext, createOrg, destroyOrg } = require('./initialization')
 
 const migrationsDirectory = path.join(__dirname, '..', '..', 'db', 'migrations')
 
-let agent
-test.before(async () => {
-  const conn = await db()
-  await conn.migrate.latest({ directory: migrationsDirectory })
-
-  // seed
-  await conn('users').insert({ id: 100 })
-  await conn('users').insert({ id: 101 })
-
-  // stub hydra introspect
-  let introspectStub = sinon.stub(hydra, 'introspect')
-  introspectStub.withArgs('user100').returns({
-    active: true,
-    sub: '100'
-  })
-
-  introspectStub.withArgs('user101').returns({
-    active: true,
-    sub: '101'
-  })
-  introspectStub.withArgs('invalidToken').returns({ active: false })
-
-  agent = require('supertest').agent(await require('../../index')())
-})
+test.before(initializeContext)
 
 test.after.always(async () => {
   const conn = await db()
   await conn.migrate.rollback({ directory: migrationsDirectory })
   conn.destroy()
 })
 
+// set up and tear down an org for each test
+test.beforeEach(createOrg)
+test.afterEach(destroyOrg)
+
 /**
  * An org owner can create a team
  * We create an org with the user100 user
  * We check that user100 can create a team in the org
  *
  */
 test('org owner can create a team', async t => {
-  const orgName = 'org owner can create a team'
   const teamName = 'org owner can create a team - team'
 
-  let res = await agent.post('/api/organizations')
-    .send({ name: orgName })
-    .set('Authorization', 'Bearer user100')
-    .expect(200)
-
-  let res2 = await agent.post(`/api/organizations/${res.body.id}/teams`)
+  let res2 = await t.context.agent.post(`/api/organizations/${t.context.org.id}/teams`)
     .set('Authorization', 'Bearer user100')
     .send({ name: teamName })
 
@@ -66,20 +40,14 @@ test('org owner can create a team', async t => {
  *
  */
 test('org manager can create a team', async t => {
-  const orgName = 'org manager can create a team'
   const teamName = 'org manager can create a team - team'
 
-  let res = await agent.post('/api/organizations')
-    .send({ name: orgName })
-    .set('Authorization', 'Bearer user100')
-    .expect(200)
-
   // We create a manager role for user 101
-  await agent.put(`/api/organizations/${res.body.id}/addManager/101`)
+  await t.context.agent.put(`/api/organizations/${t.context.org.id}/addManager/101`)
     .set('Authorization', 'Bearer user100')
     .expect(200)
 
-  let res2 = await agent.post(`/api/organizations/${res.body.id}/teams`)
+  let res2 = await t.context.agent.post(`/api/organizations/${t.context.org.id}/teams`)
     .set('Authorization', 'Bearer user101')
     .send({ name: teamName })
 
@@ -88,20 +56,13 @@ test('org manager can create a team', async t => {
 
 /**
  * An non-org manager cannot create a team
- * We create an org with the user100 user and assign user101
- * as a manager. We check that user101 can create a team in the org
+ * We create an org with the user100 user and check that a non
  *
  */
 test('non-org manager cannot create a team', async t => {
-  const orgName = 'non-org manager cannot create a team'
   const teamName = 'non-org manager cannot create a team - team'
 
-  let res = await agent.post('/api/organizations')
-    .send({ name: orgName })
-    .set('Authorization', 'Bearer user100')
-    .expect(200)
-
-  let res2 = await agent.post(`/api/organizations/${res.body.id}/teams`)
+  let res2 = await t.context.agent.post(`/api/organizations/${t.context.org.id}/teams`)
     .set('Authorization', 'Bearer user101')
     .send({ name: teamName })
 

app/tests/permissions/create-team.test.js

@@ -1,29 +1,11 @@
 const test = require('ava')
 const db = require('../../db')
 const path = require('path')
-const hydra = require('../../lib/hydra')
-const sinon = require('sinon')
+const { initializeContext } = require('./initialization')
 
 const migrationsDirectory = path.join(__dirname, '..', '..', 'db', 'migrations')
 
-let agent
-test.before(async () => {
-  const conn = await db()
-  await conn.migrate.latest({ directory: migrationsDirectory })
-
-  // seed
-  await conn('users').insert({ id: 100 })
-
-  // stub hydra introspect
-  let introspectStub = sinon.stub(hydra, 'introspect')
-  introspectStub.withArgs('validToken').returns({
-    active: true,
-    sub: '100'
-  })
-  introspectStub.withArgs('invalidToken').returns({ active: false })
-
-  agent = require('supertest').agent(await require('../../index')())
-})
+test.before(initializeContext)
 
 test.after.always(async () => {
   const conn = await db()
@@ -32,16 +14,16 @@ test.after.always(async () => {
 })
 
 test('an authenticated user can create a team', async t => {
-  let res = await agent.post('/api/teams')
+  let res = await t.context.agent.post('/api/teams')
     .send({ name: 'road team 1' })
-    .set('Authorization', `Bearer validToken`)
+    .set('Authorization', 'Bearer user100')
     .expect(200)
 
   t.is(res.body.name, 'road team 1')
 })
 
 test('an unauthenticated user cannot create a team', async t => {
-  let res = await agent.post('/api/teams')
+  let res = await t.context.agent.post('/api/teams')
     .send({ name: 'road team 2' })
 
   t.is(res.status, 401)

app/tests/permissions/delete-team.test.js

@@ -1,34 +1,11 @@
 const test = require('ava')
 const db = require('../../db')
 const path = require('path')
-const hydra = require('../../lib/hydra')
-const sinon = require('sinon')
+const { initializeContext } = require('./initialization')
 
 const migrationsDirectory = path.join(__dirname, '..', '..', 'db', 'migrations')
 
-let agent
-test.before(async () => {
-  const conn = await db()
-  await conn.migrate.latest({ directory: migrationsDirectory })
-
-  // seed
-  await conn('users').insert({ id: 100 })
-  await conn('users').insert({ id: 101 })
-
-  // stub hydra introspect
-  let introspectStub = sinon.stub(hydra, 'introspect')
-  introspectStub.withArgs('validToken').returns({
-    active: true,
-    sub: '100'
-  })
-  introspectStub.withArgs('differentUser').returns({
-    active: true,
-    sub: '101'
-  })
-  introspectStub.withArgs('invalidToken').returns({ active: false })
-
-  agent = require('supertest').agent(await require('../../index')())
-})
+test.before(initializeContext)
 
 test.after.always(async () => {
   const conn = await db()
@@ -37,25 +14,25 @@ test.after.always(async () => {
 })
 
 test('a team moderator can delete a team', async t => {
-  let res = await agent.post('/api/teams')
+  let res = await t.context.agent.post('/api/teams')
     .send({ name: 'road team 1' })
-    .set('Authorization', `Bearer validToken`)
+    .set('Authorization', `Bearer user100`)
     .expect(200)
 
-  let res2 = await agent.delete(`/api/teams/${res.body.id}`)
-    .set('Authorization', `Bearer validToken`)
+  let res2 = await t.context.agent.delete(`/api/teams/${res.body.id}`)
+    .set('Authorization', `Bearer user100`)
 
   t.is(res2.status, 200)
 })
 
 test('a non-team moderator cannot delete a team', async t => {
-  let res = await agent.post('/api/teams')
+  let res = await t.context.agent.post('/api/teams')
     .send({ name: 'road team 2' })
-    .set('Authorization', `Bearer validToken`)
+    .set('Authorization', `Bearer user100`)
     .expect(200)
 
-  let res2 = await agent.delete(`/api/teams/${res.body.id}`)
-    .set('Authorization', `Bearer differentUser`)
+  let res2 = await t.context.agent.delete(`/api/teams/${res.body.id}`)
+    .set('Authorization', `Bearer user101`)
 
   t.is(res2.status, 401)
 })

app/tests/permissions/edit-organization.test.js

@@ -1,59 +1,31 @@
 const test = require('ava')
 const db = require('../../db')
 const path = require('path')
-const hydra = require('../../lib/hydra')
-const sinon = require('sinon')
+const { initializeContext, createOrg, destroyOrg } = require('./initialization')
 
 const migrationsDirectory = path.join(__dirname, '..', '..', 'db', 'migrations')
 
-let agent
-test.before(async () => {
-  const conn = await db()
-  await conn.migrate.latest({ directory: migrationsDirectory })
-
-  // seed
-  await conn('users').insert({ id: 100 })
-  await conn('users').insert({ id: 101 })
-  await conn('users').insert({ id: 102 })
-
-  // stub hydra introspect
-  let introspectStub = sinon.stub(hydra, 'introspect')
-  introspectStub.withArgs('user100').returns({
-    active: true,
-    sub: '100'
-  })
-
-  introspectStub.withArgs('user101').returns({
-    active: true,
-    sub: '101'
-  })
-
-  introspectStub.withArgs('invalidToken').returns({ active: false })
-
-  agent = require('supertest').agent(await require('../../index')())
-})
+test.before(initializeContext)
 
 test.after.always(async () => {
   const conn = await db()
   await conn.migrate.rollback({ directory: migrationsDirectory })
   conn.destroy()
 })
 
+// set up and tear down an org for each test
+test.beforeEach(createOrg)
+test.afterEach(destroyOrg)
+
 /**
  * An org owner can update the org
  * We create an org with the user100 and then
  * see if they can edit the organization
  *
  */
 test('org owner can update an org', async t => {
-  const orgName = 'org owner can update an org'
   const orgName2 = 'org owner can update an org - org 2'
-  const res = await agent.post('/api/organizations')
-    .send({ name: orgName })
-    .set('Authorization', `Bearer user100`)
-    .expect(200)
-
-  const res2 = await agent.put(`/api/organizations/${res.body.id}`)
+  const res2 = await t.context.agent.put(`/api/organizations/${t.context.org.id}`)
     .set('Authorization', `Bearer user100`)
     .send({ name: orgName2 })
 
@@ -66,19 +38,14 @@ test('org owner can update an org', async t => {
  *
  */
 test('org manager cannot update an org', async t => {
-  const orgName = 'org manager cannot update an org'
   const orgName2 = 'org manager cannot update an org - org 2'
-  const res = await agent.post('/api/organizations')
-    .send({ name: orgName })
-    .set('Authorization', `Bearer user100`)
-    .expect(200)
 
   // We create a manager role for user 101
-  await agent.post(`/api/organizations/${res.body.id}/addManager/101`)
+  await t.context.agent.post(`/api/organizations/${t.context.org.id}/addManager/101`)
     .set('Authorization', `Bearer user100`)
     .expect(200)
 
-  const res3 = await agent.put(`/api/organizations/${res.body.id}`)
+  const res3 = await t.context.agent.put(`/api/organizations/${t.context.org.id}`)
     .set('Authorization', `Bearer user101`)
     .send({ name: orgName2 })
 
@@ -91,14 +58,9 @@ test('org manager cannot update an org', async t => {
  *
  */
 test('no-role user cannot update an org', async t => {
-  const orgName = 'no-role user cannot update an org'
   const orgName2 = 'no-role user cannot update an org - org 2'
-  const res = await agent.post('/api/organizations')
-    .send({ name: orgName })
-    .set('Authorization', `Bearer user100`)
-    .expect(200)
 
-  const res2 = await agent.put(`/api/organizations/${res.body.id}`)
+  const res2 = await t.context.agent.put(`/api/organizations/${t.context.org.id}`)
     .set('Authorization', `Bearer user101`)
     .send({ name: orgName2 })