Add/remove manager functionality

Author: kamicut

app/lib/organization.js

@@ -39,6 +39,7 @@ async function getManagers (id) {
  *
  * @param {object} data - params for an organization
  * @param {string} data.name - name of the organization
+ * @param {int} osmId - osm id of the owner
  * @return {promise}
  */
 async function create (data, osmId) {
@@ -70,6 +71,7 @@ async function destroy (id) {
  * Update an organization
  *
  * @param {int} id - organization id
+ * @param {object} data - params for an organization
  * @return {promise}
  */
 async function update (id, data) {
@@ -82,7 +84,9 @@ async function update (id, data) {
 /**
  * Add organization owner
  *
- * @param {int} id - organization owner
+ * @param {int} id - organization id
+ * @param {int} osmId - osm id of the owner
+ * @return {promise}
  */
 async function addOwner (id, osmId) {
   const conn = await db()
@@ -91,8 +95,11 @@ async function addOwner (id, osmId) {
 
 /**
  * Remove organization owner
+ * There has to be at least one owner for an organization
  *
- * @param {int} id - organization owner
+ * @param {int} id - organization id
+ * @param {int} osmId - osm id of the owner
+ * @return {promise}
  */
 async function removeOwner (id, osmId) {
   const conn = await db()
@@ -109,6 +116,37 @@ async function removeOwner (id, osmId) {
   return unpack(conn('organization_owner').where({ organization_id: id, osm_id: osmId }).del())
 }
 
+/**
+ * Add organization manager
+ *
+ * @param {int} id - organization id
+ * @param {int} osmId - osm id of the manager
+ * @return {promise}
+ */
+async function addManager (id, osmId) {
+  const conn = await db()
+  return unpack(conn('organization_manager').insert({ organization_id: id, osm_id: osmId }))
+}
+
+/**
+ * Remove organization manager
+ * There can be 0 managers in an organization
+ *
+ * @param {int} id - organization id
+ * @param {int} osmId - osm id of the manager
+ * @return {promise}
+ */
+async function removeManager (id, osmId) {
+  const conn = await db()
+  const managers = map(prop('osm_id'), await getManagers(id))
+
+  if (!contains(osmId, managers)) {
+    throw new Error('osmId is not a manager')
+  }
+
+  return unpack(conn('organization_manager').where({ organization_id: id, osm_id: osmId }).del())
+}
+
 /**
  * Checks if the osm user is an owner of a team
  * @param {int} organizationId - organization id
@@ -144,6 +182,8 @@ module.exports = {
   update,
   addOwner,
   removeOwner,
+  addManager,
+  removeManager,
   getOwners,
   getManagers,
   isOwner,

app/tests/api/organization-model.test.js

@@ -147,3 +147,47 @@ test('remove owners', async t => {
   const error2 = await t.throwsAsync(organization.removeOwner(created.id, user))
   t.is(error2.message, 'cannot remove owner because there must be at least one owner')
 })
+
+/**
+ * Test add a manager
+ * There should be 2 managers because a creator of a team is automatically
+ * assigned to be a manager
+ */
+test('add managers', async t => {
+  // setup
+  const name = 'add managers'
+  const user = 1
+  const user2 = 2
+  const created = await organization.create({ name }, user)
+  await organization.addManager(created.id, user2)
+
+  // tests
+  const managers = map(prop('osm_id'), await organization.getManagers(created.id))
+  t.is(managers.length, 2)
+  t.true(contains(user, managers))
+  t.true(contains(user2, managers))
+
+  // adding the same manager throws an error
+  await t.throwsAsync(organization.addManager(created.id, user2))
+})
+
+test('remove managers', async t => {
+  // setup
+  const name = 'remove managers'
+  const user = 1
+  const user2 = 2
+  const user3 = 3
+  const created = await organization.create({ name }, user)
+  await organization.addManager(created.id, user2)
+  await organization.removeManager(created.id, user2)
+
+  // tests
+  const managers = map(prop('osm_id'), await organization.getManagers(created.id))
+  t.is(managers.length, 1)
+  t.true(contains(user, managers))
+  t.false(contains(user2, managers))
+
+  // removing a non manager throws an error
+  const error = await t.throwsAsync(organization.removeManager(created.id, user3))
+  t.is(error.message, 'osmId is not a manager')
+})