Skip to content

Commit bb5d94b

Browse files
committed
Update placeholders, icons
1 parent 2129ce9 commit bb5d94b

File tree

5 files changed

+10
-4
lines changed

5 files changed

+10
-4
lines changed

src/components/tables/search-input.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ const SearchInput = ({ onSearch, placeholder, 'data-cy': dataCy }) => {
5353
name='search'
5454
id='search'
5555
placeholder={placeholder}
56-
style={{ width: '12rem' }}
56+
style={{ width: '12.5rem' }}
5757
/>
5858
<Button
5959
data-cy={`${dataCy}-search-submit`}

src/components/tables/table.js

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,15 @@ function TableHead({ columns, sort, setSort, onClick }) {
1414
currentSortDirection === 'asc' ? 'desc' : 'asc'
1515
let sortIcon = ''
1616
if (currentSortDirection !== 'none') {
17-
sortIcon = currentSortDirection === 'asc' ? '' : ''
17+
sortIcon = currentSortDirection === 'asc' ? '' : ''
1818
}
1919

2020
return (
2121
<th
2222
key={`table-head-column-${key}`}
2323
data-cy={`table-head-column-${key}`}
24+
className={sortable && 'sortable'}
25+
title={sortable && `Click to sort by ${key}`}
2426
onClick={() => {
2527
onClick && onClick()
2628

@@ -152,6 +154,9 @@ export default function Table({
152154
background: ${theme.colors.primaryLite};
153155
border-bottom: 4px solid ${theme.colors.primaryColor};
154156
}
157+
thead th.sortable {
158+
cursor: pointer;
159+
}
155160
156161
tbody tr td {
157162
padding: 0.875rem;

src/components/tables/users.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ function UsersTable({ type, orgId, onRowClick, isSearchable }) {
5757
setPage(1)
5858
setSearch(search)
5959
}}
60+
placeholder='Search by username'
6061
/>
6162
)}
6263
<Table

src/pages/teams/[id]/members-table.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ function MembersTable({ rows: allRows, onRowClick }) {
4949
<>
5050
<SearchInput
5151
data-cy='team-members-table'
52-
placeholder='Type an username...'
52+
placeholder='Search by username'
5353
onSearch={(search) => {
5454
// Reset to page 1 and search
5555
setPage(1)

src/pages/teams/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ export default class TeamList extends Component {
100100
<>
101101
<SearchInput
102102
data-cy='teams-table'
103-
placeholder='Search by team name...'
103+
placeholder='Search by team name'
104104
onSearch={(search) => {
105105
// Reset to page 1 and search
106106
this.setState({ page: 1, search })

0 commit comments

Comments
 (0)