Fix querystring parse test util

Author: alukach

tests/test_utils.py

@@ -3,6 +3,7 @@
 import pytest
 
 from stac_auth_proxy.utils.requests import extract_variables
+from utils import parse_query_string
 
 
 @pytest.mark.parametrize(
@@ -19,3 +20,18 @@
 def test_extract_variables(url, expected):
     """Test extracting variables from a URL path."""
     assert extract_variables(url) == expected
+
+
+@pytest.mark.parametrize(
+    "query, expected",
+    (
+        ("foo=bar", {"foo": "bar"}),
+        (
+            'filter={"xyz":"abc"}&filter-lang=cql2-json',
+            {"filter": {"xyz": "abc"}, "filter-lang": "cql2-json"},
+        ),
+    ),
+)
+def test_parse_query_string(query, expected):
+    """Validate test helper for parsing query strings."""
+    assert parse_query_string(query) == expected

tests/utils.py

@@ -54,12 +54,14 @@ def single_chunk_async_stream_response(
 
 def parse_query_string(qs: str) -> dict:
     """Parse a query string into a dictionary."""
+    # Python's parse_qs will turn dicts into strings (e.g. parse_qs('foo={"x":"y"}') == {'foo': ['{"x":"y"}']})
+    # so we need some special tooling to examine the query params and compare them to expected values
     parsed = parse_qs(qs)
 
     result = {}
     for key, value_list in parsed.items():
         value = value_list[0]
-        if key == "filter" and parsed.get("filter-lang") == "cql2-json":
+        if key == "filter" and parsed.get("filter-lang") == ["cql2-json"]:
             decoded_str = unquote(value)
             result[key] = json.loads(decoded_str)
         else: