Cleanup

Author: alukach

src/stac_auth_proxy/app.py

@@ -28,6 +28,9 @@ def create_app(settings: Optional[Settings] = None) -> FastAPI:
     """FastAPI Application Factory."""
     settings = settings or Settings()
 
+    #
+    # Application
+    #
     upstream_urls = [
         settings.upstream_url,
         settings.oidc_discovery_internal_url or settings.oidc_discovery_url,
@@ -45,20 +48,24 @@ def create_app(settings: Optional[Settings] = None) -> FastAPI:
         lifespan=lifespan,
     )
 
+    #
+    # Handlers (place catch-all proxy handler last)
+    #
     if settings.healthz_prefix:
         app.include_router(
             HealthzHandler(upstream_url=str(settings.upstream_url)).router,
             prefix=settings.healthz_prefix,
         )
 
-    proxy_handler = ReverseProxyHandler(upstream=str(settings.upstream_url))
     app.add_api_route(
         "/{path:path}",
-        proxy_handler.stream,
+        ReverseProxyHandler(upstream=str(settings.upstream_url)).stream,
         methods=["GET", "POST", "PUT", "PATCH", "DELETE"],
     )
 
-    # Add middleware in reverse order (last added = first to run)
+    #
+    # Middleware (order is important, last added = first to run)
+    #
     if settings.openapi_spec_endpoint:
         app.add_middleware(
             OpenApiMiddleware,
@@ -70,7 +77,9 @@ def create_app(settings: Optional[Settings] = None) -> FastAPI:
         )
 
     if settings.items_filter:
-        app.add_middleware(ApplyCql2FilterMiddleware)
+        app.add_middleware(
+            ApplyCql2FilterMiddleware,
+        )
         app.add_middleware(
             BuildCql2FilterMiddleware,
             items_filter=settings.items_filter(),
@@ -85,6 +94,8 @@ def create_app(settings: Optional[Settings] = None) -> FastAPI:
         oidc_config_internal_url=settings.oidc_discovery_internal_url,
     )
 
-    app.add_middleware(AddProcessTimeHeaderMiddleware)
+    app.add_middleware(
+        AddProcessTimeHeaderMiddleware,
+    )
 
     return app