-
Notifications
You must be signed in to change notification settings - Fork 3
Description
We are currently publishing Helm charts on every deployment to main:
stac-auth-proxy/.github/workflows/publish-helm.yaml
Lines 1 to 11 in aaf3802
| name: Publish Helm Chart | |
| on: | |
| push: | |
| branches: | |
| - main | |
| paths: | |
| - 'helm/**' | |
| - '.github/workflows/publish-helm.yaml' | |
| release: | |
| types: [created] |
I assume that we should likely version these charts and only publish on release, similar to how we treat our Docker images:
stac-auth-proxy/.github/workflows/publish-docker.yaml
Lines 1 to 5 in aaf3802
| name: Publish Docker image | |
| on: | |
| release: | |
| types: [published] |
@batpad please correct me if I'm misunderstanding the nature of how Helm charts are typically managed.
Removing the on: push section of our actions is trivial. However, I'm unsure where we should inject ${{ github.event.release.tag_name }} for proper tagging. For whatever reason, we get pretty funky with our Docker Images:
stac-auth-proxy/.github/workflows/publish-docker.yaml
Lines 32 to 48 in aaf3802
| - name: Extract metadata (tags, labels) for Docker | |
| id: meta | |
| uses: docker/metadata-action@v5 | |
| with: | |
| images: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }} | |
| tags: | | |
| type=raw,value=${{ github.event.release.tag_name }} | |
| type=raw,value=latest,enable=${{ github.event.release.prerelease == false }} | |
| - name: Build and push Docker image | |
| uses: docker/build-push-action@v5 | |
| with: | |
| context: . | |
| push: true | |
| platforms: linux/amd64,linux/arm64 | |
| tags: ${{ steps.meta.outputs.tags }} | |
| labels: ${{ steps.meta.outputs.labels }} |