Skip to content

Commit 7980e4e

Browse files
committed
fix: Provide keys are array components
1 parent 6b9b9c5 commit 7980e4e

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

src/pages/ItemDetail/PropertyList.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,9 @@ function PropertyList({ properties, headerLevel = "h2" }: PropertyListProps) {
2020
.filter(([ key ]: PropType) => !IGNORE_PROPS.includes(key))
2121
.map(([ key, val ]: PropType, index: number) => (
2222
(val.itemOrder && val.itemOrder.length > 1) ? (
23-
<>
23+
<Box key={key}>
2424
<Text>{val.label}</Text>
25-
<TableContainer key={key}>
25+
<TableContainer>
2626
<Table size="sm">
2727
<Thead>
2828
<Tr>
@@ -34,7 +34,7 @@ function PropertyList({ properties, headerLevel = "h2" }: PropertyListProps) {
3434
</Thead>
3535
<Tbody>
3636
{ val.value.map((value) => (
37-
<Tr key={value.name}>
37+
<Tr key={JSON.stringify(value)}>
3838
{val.itemOrder.map((item) => (
3939
<Td key={item} valign="top">
4040
<TableValue value={value[item]} />
@@ -45,7 +45,7 @@ function PropertyList({ properties, headerLevel = "h2" }: PropertyListProps) {
4545
</Tbody>
4646
</Table>
4747
</TableContainer>
48-
</>
48+
</Box>
4949
) : (
5050
<Box
5151
key={key}

src/pages/ItemDetail/TableValue.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@ function TableValue({ value }: TableValueProps) {
88
if (Array.isArray(value)) {
99
return (
1010
<UnorderedList my="0">
11-
{value.map(v => <ListItem key={v}>{v}</ListItem>)}
11+
{/* eslint-disable-next-line react/no-array-index-key */}
12+
{value.map((v, i) => <ListItem key={`${i}-${v}`}>{v}</ListItem>)}
1213
</UnorderedList>
1314
);
1415
}

0 commit comments

Comments
 (0)