Skip to content

Conversation

@jverrydt
Copy link
Contributor

Available PR templates

@jverrydt
Copy link
Contributor Author

jverrydt commented Jul 1, 2025

@vincentsarago Tests are failing due to resampling/reproject being None. This default has been removed in the DatasetParams and it says it should take the rio-tiler's default but this does not seem to happen. Is this is a known issue or did I mis something?
https://github.com/developmentseed/titiler/blob/main/src/titiler/core/titiler/core/dependencies.py#L414-L427

@vincentsarago
Copy link
Member

@jverrydt yes, we now use .as_dict() to extract parameters from dependencies

https://github.com/developmentseed/titiler/blob/995e8330b6e695dba811c32adc5e9488b1bc2900/src/titiler/core/titiler/core/factory.py#L863-L865

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.42%. Comparing base (5bd7dfd) to head (642a3af).
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
+ Coverage   81.89%   82.42%   +0.52%     
==========================================
  Files          13       13              
  Lines         856      859       +3     
  Branches      103      103              
==========================================
+ Hits          701      708       +7     
+ Misses        103      101       -2     
+ Partials       52       50       -2     
Flag Coverage Δ
unittests 82.42% <100.00%> (+0.52%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vincentsarago vincentsarago merged commit 6c55a6d into developmentseed:main Nov 6, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants