Skip to content

Commit 6e6e6a8

Browse files
yangcao77yangcao77
authored
reduce endpoint name length limitation to 15 chars, validate on port duplication (#702)
* update validation & schema Signed-off-by: Stephanie <[email protected]> * fix build error Signed-off-by: Stephanie <[email protected]> * update generater to only shorten endpoint name length limit in devfile spec Signed-off-by: Stephanie <[email protected]> * fix api test Signed-off-by: Stephanie <[email protected]>
1 parent dd1d65d commit 6e6e6a8

31 files changed

+342
-90
lines changed

‎crds/workspace.devfile.io_devworkspaces.v1beta1.yaml‎

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -454,6 +454,7 @@ spec:
454454
`wss`.
455455
type: boolean
456456
targetPort:
457+
description: The port number should be unique.
457458
type: integer
458459
required:
459460
- name
@@ -751,6 +752,7 @@ spec:
751752
`wss`.
752753
type: boolean
753754
targetPort:
755+
description: The port number should be unique.
754756
type: integer
755757
required:
756758
- name
@@ -869,6 +871,7 @@ spec:
869871
`wss`.
870872
type: boolean
871873
targetPort:
874+
description: The port number should be unique.
872875
type: integer
873876
required:
874877
- name
@@ -1259,6 +1262,8 @@ spec:
12591262
a protocol of `https` or `wss`.
12601263
type: boolean
12611264
targetPort:
1265+
description: The port number should be
1266+
unique.
12621267
type: integer
12631268
required:
12641269
- name
@@ -1552,6 +1557,8 @@ spec:
15521557
a protocol of `https` or `wss`.
15531558
type: boolean
15541559
targetPort:
1560+
description: The port number should be
1561+
unique.
15551562
type: integer
15561563
required:
15571564
- name
@@ -1681,6 +1688,8 @@ spec:
16811688
a protocol of `https` or `wss`.
16821689
type: boolean
16831690
targetPort:
1691+
description: The port number should be
1692+
unique.
16841693
type: integer
16851694
required:
16861695
- name
@@ -2166,6 +2175,7 @@ spec:
21662175
or `wss`.
21672176
type: boolean
21682177
targetPort:
2178+
description: The port number should be unique.
21692179
type: integer
21702180
required:
21712181
- name
@@ -2442,6 +2452,7 @@ spec:
24422452
or `wss`.
24432453
type: boolean
24442454
targetPort:
2455+
description: The port number should be unique.
24452456
type: integer
24462457
required:
24472458
- name
@@ -2561,6 +2572,7 @@ spec:
25612572
or `wss`.
25622573
type: boolean
25632574
targetPort:
2575+
description: The port number should be unique.
25642576
type: integer
25652577
required:
25662578
- name
@@ -2965,6 +2977,8 @@ spec:
29652977
or `wss`.
29662978
type: boolean
29672979
targetPort:
2980+
description: The port number should
2981+
be unique.
29682982
type: integer
29692983
required:
29702984
- name
@@ -3276,6 +3290,8 @@ spec:
32763290
or `wss`.
32773291
type: boolean
32783292
targetPort:
3293+
description: The port number should
3294+
be unique.
32793295
type: integer
32803296
required:
32813297
- name
@@ -3412,6 +3428,8 @@ spec:
34123428
or `wss`.
34133429
type: boolean
34143430
targetPort:
3431+
description: The port number should
3432+
be unique.
34153433
type: integer
34163434
required:
34173435
- name

‎crds/workspace.devfile.io_devworkspaces.yaml‎

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -462,6 +462,7 @@ spec:
462462
or `wss`.
463463
type: boolean
464464
targetPort:
465+
description: The port number should be unique.
465466
type: integer
466467
required:
467468
- name
@@ -764,6 +765,7 @@ spec:
764765
or `wss`.
765766
type: boolean
766767
targetPort:
768+
description: The port number should be unique.
767769
type: integer
768770
required:
769771
- name
@@ -885,6 +887,7 @@ spec:
885887
or `wss`.
886888
type: boolean
887889
targetPort:
890+
description: The port number should be unique.
888891
type: integer
889892
required:
890893
- name
@@ -1282,6 +1285,8 @@ spec:
12821285
`wss`.
12831286
type: boolean
12841287
targetPort:
1288+
description: The port number should
1289+
be unique.
12851290
type: integer
12861291
required:
12871292
- name
@@ -1583,6 +1588,8 @@ spec:
15831588
`wss`.
15841589
type: boolean
15851590
targetPort:
1591+
description: The port number should
1592+
be unique.
15861593
type: integer
15871594
required:
15881595
- name
@@ -1715,6 +1722,8 @@ spec:
17151722
`wss`.
17161723
type: boolean
17171724
targetPort:
1725+
description: The port number should
1726+
be unique.
17181727
type: integer
17191728
required:
17201729
- name
@@ -2203,6 +2212,7 @@ spec:
22032212
protocol of `https` or `wss`.
22042213
type: boolean
22052214
targetPort:
2215+
description: The port number should be unique.
22062216
type: integer
22072217
required:
22082218
- name
@@ -2484,6 +2494,7 @@ spec:
24842494
protocol of `https` or `wss`.
24852495
type: boolean
24862496
targetPort:
2497+
description: The port number should be unique.
24872498
type: integer
24882499
required:
24892500
- name
@@ -2605,6 +2616,7 @@ spec:
26052616
protocol of `https` or `wss`.
26062617
type: boolean
26072618
targetPort:
2619+
description: The port number should be unique.
26082620
type: integer
26092621
required:
26102622
- name
@@ -3017,6 +3029,8 @@ spec:
30173029
of `https` or `wss`.
30183030
type: boolean
30193031
targetPort:
3032+
description: The port number should
3033+
be unique.
30203034
type: integer
30213035
required:
30223036
- name
@@ -3332,6 +3346,8 @@ spec:
33323346
of `https` or `wss`.
33333347
type: boolean
33343348
targetPort:
3349+
description: The port number should
3350+
be unique.
33353351
type: integer
33363352
required:
33373353
- name
@@ -3471,6 +3487,8 @@ spec:
34713487
of `https` or `wss`.
34723488
type: boolean
34733489
targetPort:
3490+
description: The port number should
3491+
be unique.
34743492
type: integer
34753493
required:
34763494
- name

‎crds/workspace.devfile.io_devworkspacetemplates.v1beta1.yaml‎

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -419,6 +419,7 @@ spec:
419419
This requires a protocol of `https` or `wss`.
420420
type: boolean
421421
targetPort:
422+
description: The port number should be unique.
422423
type: integer
423424
required:
424425
- name
@@ -710,6 +711,7 @@ spec:
710711
This requires a protocol of `https` or `wss`.
711712
type: boolean
712713
targetPort:
714+
description: The port number should be unique.
713715
type: integer
714716
required:
715717
- name
@@ -822,6 +824,7 @@ spec:
822824
This requires a protocol of `https` or `wss`.
823825
type: boolean
824826
targetPort:
827+
description: The port number should be unique.
825828
type: integer
826829
required:
827830
- name
@@ -1202,6 +1205,7 @@ spec:
12021205
protocol of `https` or `wss`.
12031206
type: boolean
12041207
targetPort:
1208+
description: The port number should be unique.
12051209
type: integer
12061210
required:
12071211
- name
@@ -1483,6 +1487,7 @@ spec:
14831487
protocol of `https` or `wss`.
14841488
type: boolean
14851489
targetPort:
1490+
description: The port number should be unique.
14861491
type: integer
14871492
required:
14881493
- name
@@ -1604,6 +1609,7 @@ spec:
16041609
protocol of `https` or `wss`.
16051610
type: boolean
16061611
targetPort:
1612+
description: The port number should be unique.
16071613
type: integer
16081614
required:
16091615
- name
@@ -2071,6 +2077,7 @@ spec:
20712077
`wss`.
20722078
type: boolean
20732079
targetPort:
2080+
description: The port number should be unique.
20742081
type: integer
20752082
required:
20762083
- name
@@ -2340,6 +2347,7 @@ spec:
23402347
`wss`.
23412348
type: boolean
23422349
targetPort:
2350+
description: The port number should be unique.
23432351
type: integer
23442352
required:
23452353
- name
@@ -2457,6 +2465,7 @@ spec:
24572465
`wss`.
24582466
type: boolean
24592467
targetPort:
2468+
description: The port number should be unique.
24602469
type: integer
24612470
required:
24622471
- name
@@ -2846,6 +2855,8 @@ spec:
28462855
a protocol of `https` or `wss`.
28472856
type: boolean
28482857
targetPort:
2858+
description: The port number should be
2859+
unique.
28492860
type: integer
28502861
required:
28512862
- name
@@ -3139,6 +3150,8 @@ spec:
31393150
a protocol of `https` or `wss`.
31403151
type: boolean
31413152
targetPort:
3153+
description: The port number should be
3154+
unique.
31423155
type: integer
31433156
required:
31443157
- name
@@ -3268,6 +3281,8 @@ spec:
32683281
a protocol of `https` or `wss`.
32693282
type: boolean
32703283
targetPort:
3284+
description: The port number should be
3285+
unique.
32713286
type: integer
32723287
required:
32733288
- name

0 commit comments

Comments
 (0)