Fix potential nil error in generator

amisevsk · amisevsk · commit 98f8c7795c02 · 2022-09-19T13:50:45.000-04:00
Fix potential nil error in generator if attempting to update JSON schema
for a field that has the 'endpoints' property but isn't a
ContainerComponent (e.g. a Pod spec).

Signed-off-by: Angel Misevski &lt;amisevsk@redhat.com&gt;
diff --git a/generator/schemas/gen.go b/generator/schemas/gen.go
@@ -288,7 +288,7 @@ This is not the case in the "%s' API group:
 					return
 				}
 				for propName, prop := range schema.Properties {
-					if propName == "endpoints" {
+					if propName == "endpoints" && prop.Items != nil && prop.Items.Schema != nil {
 						for endpointPropName, endpointProp := range prop.Items.Schema.Properties {
 							if endpointPropName == "name" {
 								if schemaGenerateMarker.ShortenEndpointNameLength {

Original file line number	Diff line number	Diff line change
`@@ -288,7 +288,7 @@ This is not the case in the "%s' API group:`
`288`	`288`	`return`
`289`	`289`	`}`
`290`	`290`	`for propName, prop := range schema.Properties {`
`291`		`- if propName == "endpoints" {`
	`291`	`+ if propName == "endpoints" && prop.Items != nil && prop.Items.Schema != nil {`
`292`	`292`	`for endpointPropName, endpointProp := range prop.Items.Schema.Properties {`
`293`	`293`	`if endpointPropName == "name" {`
`294`	`294`	`if schemaGenerateMarker.ShortenEndpointNameLength {`