Skip to content

Commit da05a3e

Browse files
authored
update boolean properties (#586)
* update boolean properties * update additional tests * Update error message * Rename endpoint test file
1 parent da620cd commit da05a3e

15 files changed

+204
-69
lines changed

pkg/apis/workspaces/v1alpha2/commands.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ type CommandGroup struct {
3434

3535
// +optional
3636
// Identifies the default command for a given group kind
37-
IsDefault bool `json:"isDefault,omitempty"`
37+
IsDefault *bool `json:"isDefault,omitempty"`
3838
}
3939

4040
type BaseCommand struct {
@@ -144,7 +144,7 @@ type ExecCommand struct {
144144
// If set to `true` the command won't be restarted and it is expected to handle file changes on its own.
145145
//
146146
// Default value is `false`
147-
HotReloadCapable bool `json:"hotReloadCapable,omitempty"`
147+
HotReloadCapable *bool `json:"hotReloadCapable,omitempty"`
148148
}
149149

150150
type ApplyCommand struct {
@@ -163,7 +163,7 @@ type CompositeCommand struct {
163163

164164
// Indicates if the sub-commands should be executed concurrently
165165
// +optional
166-
Parallel bool `json:"parallel,omitempty"`
166+
Parallel *bool `json:"parallel,omitempty"`
167167
}
168168

169169
type CustomCommand struct {

pkg/apis/workspaces/v1alpha2/component_container.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ type Container struct {
6969
//
7070
// Default value is `false`
7171
// +optional
72-
DedicatedPod bool `json:"dedicatedPod,omitempty"`
72+
DedicatedPod *bool `json:"dedicatedPod,omitempty"`
7373
}
7474

7575
type EnvVar struct {

pkg/apis/workspaces/v1alpha2/component_volume.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,5 +15,5 @@ type Volume struct {
1515
// +optional
1616
// Ephemeral volumes are not stored persistently across restarts. Defaults
1717
// to false
18-
Ephemeral bool `json:"ephemeral,omitempty"`
18+
Ephemeral *bool `json:"ephemeral,omitempty"`
1919
}

pkg/apis/workspaces/v1alpha2/endpoint.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ type Endpoint struct {
9494
// Describes whether the endpoint should be secured and protected by some
9595
// authentication process. This requires a protocol of `https` or `wss`.
9696
// +optional
97-
Secure bool `json:"secure,omitempty"`
97+
Secure *bool `json:"secure,omitempty"`
9898

9999
// Path of the endpoint URL
100100
// +optional

0 commit comments

Comments
 (0)