Skip to content

Commit 24efb2d

Browse files
committed
fixup! chore: push base image to registry; update smoke tests to pull images
Signed-off-by: Oleksii Kurinnyi <[email protected]>
1 parent 6e70d37 commit 24efb2d

File tree

2 files changed

+20
-48
lines changed

2 files changed

+20
-48
lines changed

.github/workflows/pr-check-ubi10.yaml

Lines changed: 10 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -52,17 +52,9 @@ jobs:
5252
--platform linux/${{env.arch}} \
5353
--progress=plain \
5454
--push \
55-
-t ${{ env.REGISTRY }}/base-developer-image:${{env.arch}}-ubi10-pr-${{github.event.number}} \
56-
-t base-developer-image-${{env.arch}} .
55+
-t ${{ env.REGISTRY }}/base-developer-image:${{env.arch}}-ubi10-pr-${{github.event.number}} .
5756
- name: Display docker images
5857
run: docker images
59-
- name: Compress image to a file
60-
run: docker save base-developer-image-${{env.arch}} | gzip > base-developer-image-${{env.arch}}.tgz
61-
- name: Upload image artifact
62-
uses: actions/upload-artifact@v4
63-
with:
64-
name: base-developer-image-${{env.arch}}
65-
path: base-developer-image-${{env.arch}}.tgz
6658

6759

6860
build-udi:
@@ -87,28 +79,22 @@ jobs:
8779
run: sudo rm -rf /usr/local/lib/android
8880
- name: Cleanup docker images
8981
run: docker system prune -af
90-
- name: Download BDI artifacts
91-
uses: actions/download-artifact@v4
82+
- name: Login to Registry
83+
uses: docker/login-action@v3
9284
with:
93-
pattern: base-developer-image-*
94-
merge-multiple: true
95-
path: .
96-
- name: List downloaded files
97-
run: ls -lah
98-
- name: Load docker images
99-
run: docker load -i base-developer-image-${{env.arch}}.tgz
85+
registry: ${{ env.REGISTRY }}
86+
username: ${{ secrets.QUAY_USERNAME }}
87+
password: ${{ secrets.QUAY_PASSWORD }}
88+
- name: Pull base image
89+
run: |
90+
docker pull ${{ env.REGISTRY }}/base-developer-image:${{env.arch}}-ubi10-pr-${{github.event.number}}
91+
docker tag ${{ env.REGISTRY }}/base-developer-image:${{env.arch}}-ubi10-pr-${{github.event.number}} base-developer-image-${{env.arch}}
10092
- name: Display docker images
10193
run: docker images
10294
- name: Update UDI Dockerfile
10395
run: sed "s|quay.io/devfile/base-developer-image:ubi10-latest|base-developer-image-${{env.arch}}|" -i "universal/ubi10/Dockerfile"
10496
- name: Add expiration label to UDI Dockerfile
10597
run: sed -i '/^FROM/a LABEL quay.expires-after=4w' universal/ubi10/Dockerfile
106-
- name: Login to Registry
107-
uses: docker/login-action@v3
108-
with:
109-
registry: ${{ env.REGISTRY }}
110-
username: ${{ secrets.QUAY_USERNAME }}
111-
password: ${{ secrets.QUAY_PASSWORD }}
11298
- name: Build udi
11399
run: |
114100
cd universal/ubi10 && docker buildx build \

.github/workflows/pr-check.yaml

Lines changed: 10 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -52,17 +52,9 @@ jobs:
5252
--platform linux/${{env.arch}} \
5353
--progress=plain \
5454
--push \
55-
-t ${{ env.REGISTRY }}/base-developer-image:${{env.arch}}-pr-${{github.event.number}} \
56-
-t base-developer-image-${{env.arch}} .
55+
-t ${{ env.REGISTRY }}/base-developer-image:${{env.arch}}-pr-${{github.event.number}} .
5756
- name: Display docker images
5857
run: docker images
59-
- name: Compress image to a file
60-
run: docker save base-developer-image-${{env.arch}} | gzip > base-developer-image-${{env.arch}}.tgz
61-
- name: Upload image artifact
62-
uses: actions/upload-artifact@v4
63-
with:
64-
name: base-developer-image-${{env.arch}}
65-
path: base-developer-image-${{env.arch}}.tgz
6658

6759
build-udi:
6860
name: Build udi
@@ -86,28 +78,22 @@ jobs:
8678
run: sudo rm -rf /usr/local/lib/android
8779
- name: Cleanup docker images
8880
run: docker system prune -af
89-
- name: Download BDI artifacts
90-
uses: actions/download-artifact@v4
81+
- name: Login to Registry
82+
uses: docker/login-action@v3
9183
with:
92-
pattern: base-developer-image-*
93-
merge-multiple: true
94-
path: .
95-
- name: List downloaded files
96-
run: ls -lah
97-
- name: Load docker images
98-
run: docker load -i base-developer-image-${{env.arch}}.tgz
84+
registry: ${{ env.REGISTRY }}
85+
username: ${{ secrets.QUAY_USERNAME }}
86+
password: ${{ secrets.QUAY_PASSWORD }}
87+
- name: Pull base image
88+
run: |
89+
docker pull ${{ env.REGISTRY }}/base-developer-image:${{env.arch}}-pr-${{github.event.number}}
90+
docker tag ${{ env.REGISTRY }}/base-developer-image:${{env.arch}}-pr-${{github.event.number}} base-developer-image-${{env.arch}}
9991
- name: Display docker images
10092
run: docker images
10193
- name: Update UDI Dockerfile
10294
run: sed "s|quay.io/devfile/base-developer-image:ubi9-latest|base-developer-image-${{env.arch}}|" -i "universal/ubi9/Dockerfile"
10395
- name: Add expiration label to UDI Dockerfile
10496
run: sed -i '/^FROM/a LABEL quay.expires-after=4w' universal/ubi9/Dockerfile
105-
- name: Login to Registry
106-
uses: docker/login-action@v3
107-
with:
108-
registry: ${{ env.REGISTRY }}
109-
username: ${{ secrets.QUAY_USERNAME }}
110-
password: ${{ secrets.QUAY_PASSWORD }}
11197
- name: Build udi
11298
run: |
11399
cd universal/ubi9 && docker buildx build \

0 commit comments

Comments
 (0)