fix: support env var for postStart commands

Signed-off-by: Oleksii Kurinnyi <[email protected]>

Author: akurinnoy

pkg/library/lifecycle/poststart.go

@@ -163,14 +163,13 @@ func buildUserScript(commands []dw.Command) (string, error) {
 			// Should be caught by earlier validation, but good to be safe
 			return "", fmt.Errorf("exec command is nil for command ID %s", command.Id)
 		}
-		if len(execCmd.Env) > 0 {
-			return "", fmt.Errorf("env vars in postStart command %s are unsupported", command.Id)
-		}
 		var singleCommandParts []string
+		for _, envVar := range execCmd.Env {
+			singleCommandParts = append(singleCommandParts, fmt.Sprintf("export %s=%q", envVar.Name, envVar.Value))
+		}
+
 		if execCmd.WorkingDir != "" {
-			// Safely quote the working directory path
-			safeWorkingDir := strings.ReplaceAll(execCmd.WorkingDir, "'", `'\''`)
-			singleCommandParts = append(singleCommandParts, fmt.Sprintf("cd '%s'", safeWorkingDir))
+			singleCommandParts = append(singleCommandParts, fmt.Sprintf("cd %q", execCmd.WorkingDir))
 		}
 		if execCmd.CommandLine != "" {
 			singleCommandParts = append(singleCommandParts, execCmd.CommandLine)

pkg/library/lifecycle/poststart_test.go

@@ -132,7 +132,7 @@ func TestBuildUserScript(t *testing.T) {
 					},
 				},
 			},
-			expectedScript: "cd '/projects/app' && ls -la",
+			expectedScript: "cd \"/projects/app\" && ls -la",
 			expectedErr:    "",
 		},
 		{
@@ -148,7 +148,7 @@ func TestBuildUserScript(t *testing.T) {
 					},
 				},
 			},
-			expectedScript: "cd '/data'",
+			expectedScript: "cd \"/data\"",
 			expectedErr:    "",
 		},
 		{
@@ -165,7 +165,7 @@ func TestBuildUserScript(t *testing.T) {
 					},
 				},
 			},
-			expectedScript: "cd '/projects/app'\\''s' && cat file.txt",
+			expectedScript: "cd \"/projects/app's\" && cat file.txt",
 			expectedErr:    "",
 		},
 		{
@@ -201,11 +201,11 @@ func TestBuildUserScript(t *testing.T) {
 					},
 				},
 			},
-			expectedScript: "cd '/projects/frontend' && npm install\nnpm start\ncd '/projects/backend' && mvn spring-boot:run",
+			expectedScript: "cd \"/projects/frontend\" && npm install\nnpm start\ncd \"/projects/backend\" && mvn spring-boot:run",
 			expectedErr:    "",
 		},
 		{
-			name: "Command with unsupported Env vars",
+			name: "Command with Env vars",
 			commands: []dw.Command{
 				{
 					Id: "cmd-with-env",
@@ -220,8 +220,8 @@ func TestBuildUserScript(t *testing.T) {
 					},
 				},
 			},
-			expectedScript: "",
-			expectedErr:    "env vars in postStart command cmd-with-env are unsupported",
+			expectedScript: "export MY_VAR=\"test\" && echo $MY_VAR",
+			expectedErr:    "",
 		},
 		{
 			name: "Command with nil Exec field",