Skip to content

Commit 40d7607

Browse files
AObuchowdkwon17
authored andcommitted
fix: temporarily pin goimports in GH Actions to v0.24.0
Part of #1314 The latest version of goimports (v0.25.0) requires go >= 1.22.0. Since we are about to do the upstream release of DWO 0.31.0, we are temporarily pinning goimports to the last working version (v0.24.0). After the 0.31.0 release of DWO, we can safely upgrade the entire repo to go 1.22.0, and use the latest version of goimports again. Signed-off-by: Andrew Obuchowicz <[email protected]>
1 parent cc0c246 commit 40d7607

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

.github/workflows/code-coverage.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ jobs:
4040
name: Run Go Tests
4141
run: |
4242
python -m pip install --upgrade pip yq
43-
go install golang.org/x/tools/cmd/goimports@latest
43+
go install golang.org/x/tools/cmd/goimports@v0.24.0
4444
go install github.com/onsi/ginkgo/v2/[email protected]
4545
make update_devworkspace_crds test
4646
-

.github/workflows/pr.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ jobs:
7373
name: Check format
7474
run: |
7575
go install github.com/google/addlicense@latest
76-
go install golang.org/x/tools/cmd/goimports@latest
76+
go install golang.org/x/tools/cmd/goimports@v0.24.0
7777
if ! make check_fmt; then
7878
echo "not well formatted sources are found:"
7979
git --no-pager diff

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ jobs:
121121
run: |
122122
# Need to grab goimports otherwise formatting after this step will fail
123123
# PR checks.
124-
go install golang.org/x/tools/cmd/goimports@latest
124+
go install golang.org/x/tools/cmd/goimports@v0.24.0
125125
126126
git config --global user.name "Andrew Obuchowicz"
127127
git config --global user.email "[email protected]"

0 commit comments

Comments
 (0)