Skip to content

Commit 65e80f4

Browse files
committed
fixup! fix: conditionally add SSH agent postStart event
1 parent 157e20a commit 65e80f4

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

controllers/workspace/devworkspace_controller.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -283,8 +283,7 @@ func (r *DevWorkspaceReconciler) Reconcile(ctx context.Context, req ctrl.Request
283283

284284
if workspace.Config.EnableExperimentalFeatures != nil && *workspace.Config.EnableExperimentalFeatures {
285285
if needsSSHAgentPostStartEvent, err := ssh.NeedsSSHPostStartEvent(clusterAPI, workspace.Namespace); err != nil {
286-
// TODO: Should we fail the workspace? Or log the error and continue on?
287-
return r.failWorkspace(workspace, fmt.Sprintf("Error retrieving SSH secret: %s", err), metrics.ReasonInfrastructureFailure, reqLogger, &reconcileStatus), nil
286+
reqLogger.Error(err, "Error retrieving SSH secret")
288287
} else if needsSSHAgentPostStartEvent {
289288
if err = ssh.AddSshAgentPostStartEvent(&workspace.Spec.Template); err != nil {
290289
return r.failWorkspace(workspace, "Failed to add ssh-agent post start event", metrics.ReasonWorkspaceEngineFailure, reqLogger, &reconcileStatus), nil

0 commit comments

Comments
 (0)