feat : [CRW-5722] Add configuration option in DevWorkspaceOperatorConfig for storage access mode (#1019)

- Add configuration option named StorageAccessMode in WorkspaceConfig struct
- Set PVC accessMode if abovementioned option is set in WorkspaceConfig, default
  to ReadWriteOnce

Signed-off-by: Rohan Kumar <[email protected]>

Author: rohanKanojia

apis/controller/v1alpha1/devworkspaceoperatorconfig_types.go

@@ -135,6 +135,9 @@ type WorkspaceConfig struct {
 	// DefaultStorageSize defines an optional struct with fields to specify the sizes of Persistent Volume Claims for storage
 	// classes used by DevWorkspaces.
 	DefaultStorageSize *StorageSizes `json:"defaultStorageSize,omitempty"`
+	// StorageAccessMode are the desired access modes the volume should have. It defaults
+	// to ReadWriteOnce if not specified
+	StorageAccessMode []corev1.PersistentVolumeAccessMode `json:"storageAccessMode,omitempty"`
 	// PersistUserHome defines configuration options for persisting the `/home/user/`
 	// directory in workspaces.
 	PersistUserHome *PersistentHomeConfig `json:"persistUserHome,omitempty"`

apis/controller/v1alpha1/zz_generated.deepcopy.go

@@ -341,6 +341,9 @@ func mergeConfig(from, to *controller.OperatorConfiguration) {
 		if from.Workspace.ContainerSecurityContext != nil {
 			to.Workspace.ContainerSecurityContext = mergeContainerSecurityContext(to.Workspace.ContainerSecurityContext, from.Workspace.ContainerSecurityContext)
 		}
+		if from.Workspace.StorageAccessMode != nil {
+			to.Workspace.StorageAccessMode = from.Workspace.StorageAccessMode
+		}
 		if from.Workspace.DefaultStorageSize != nil {
 			if to.Workspace.DefaultStorageSize == nil {
 				to.Workspace.DefaultStorageSize = &controller.StorageSizes{}

deploy/bundle/manifests/controller.devfile.io_devworkspaceoperatorconfigs.yaml

@@ -107,6 +107,9 @@ func TestMergesAllFieldsFromClusterConfig(t *testing.T) {
 				*deploymentStrategy = appsv1.RecreateDeploymentStrategyType
 			}
 		},
+		func(accessModes *[]corev1.PersistentVolumeAccessMode, c fuzz.Continue) {
+			accessModes = nil
+		},
 		fuzzQuantity,
 		fuzzResourceList,
 		fuzzResourceRequirements,
@@ -428,6 +431,9 @@ func TestMergeConfigHandlesProxySettings(t *testing.T) {
 func TestMergeConfigLooksAtAllFields(t *testing.T) {
 	f := fuzz.New().NilChance(0).Funcs(
 		func(embeddedResource *runtime.RawExtension, c fuzz.Continue) {},
+		func(accessModes *[]corev1.PersistentVolumeAccessMode, c fuzz.Continue) {
+			accessModes = nil
+		},
 		fuzzQuantity,
 		fuzzResourceList,
 		fuzzResourceRequirements,
@@ -440,6 +446,24 @@ func TestMergeConfigLooksAtAllFields(t *testing.T) {
 	assert.Equal(t, expectedConfig, actualConfig, "merging configs should merge all fields")
 }
 
+func TestMergeConfigMergesStorageAccessMode(t *testing.T) {
+	// Given
+	expectedConfig := &v1alpha1.OperatorConfiguration{
+		Workspace: &v1alpha1.WorkspaceConfig{
+			StorageAccessMode: []corev1.PersistentVolumeAccessMode{
+				corev1.ReadWriteMany,
+			},
+		},
+	}
+	actualConfig := &v1alpha1.OperatorConfiguration{}
+
+	// When
+	mergeConfig(expectedConfig, actualConfig)
+
+	// Then
+	assert.Equal(t, expectedConfig.Workspace.StorageAccessMode, actualConfig.Workspace.StorageAccessMode)
+}
+
 func fuzzQuantity(q *resource.Quantity, c fuzz.Continue) {
 	q.Set(c.Int63n(999))
 	q.Format = resource.DecimalSI