chore: remove excecive defensive checks

Signed-off-by: Oleksii Kurinnyi <[email protected]>

Author: akurinnoy

controllers/controller/devworkspacerouting/devworkspacerouting_controller.go

@@ -215,10 +215,6 @@ func (r *DevWorkspaceRoutingReconciler) Reconcile(ctx context.Context, req ctrl.
 			if errors.As(err, &failError) {
 				return reconcile.Result{}, r.markRoutingFailed(instance, err.Error())
 			}
-			conflictErr := &solvers.HostnameConflictError{}
-			if errors.As(err, &conflictErr) {
-				return reconcile.Result{}, r.markRoutingFailed(instance, conflictErr.Error())
-			}
 			reqLogger.Error(err, "Error syncing routes")
 			return reconcile.Result{Requeue: true}, r.reconcileStatus(instance, nil, nil, false, "Preparing routes")
 		} else if !routesInSync {
@@ -233,10 +229,6 @@ func (r *DevWorkspaceRoutingReconciler) Reconcile(ctx context.Context, req ctrl.
 			if errors.As(err, &failError) {
 				return reconcile.Result{}, r.markRoutingFailed(instance, err.Error())
 			}
-			conflictErr := &solvers.HostnameConflictError{}
-			if errors.As(err, &conflictErr) {
-				return reconcile.Result{}, r.markRoutingFailed(instance, conflictErr.Error())
-			}
 			reqLogger.Error(err, "Error syncing ingresses")
 			return reconcile.Result{Requeue: true}, r.reconcileStatus(instance, nil, nil, false, "Preparing ingresses")
 		} else if !ingressesInSync {

controllers/controller/devworkspacerouting/solvers/errors.go

@@ -21,18 +21,6 @@ import (
 )
 
 var _ error = (*RoutingNotReady)(nil)
-
-// HostnameConflictError is an error returned when a hostname required by a DevWorkspace is already in use
-// by another resource on the cluster.
-type HostnameConflictError struct {
-	// Reason provides a textual summary of the conflict
-	Reason string
-}
-
-func (e *HostnameConflictError) Error() string {
-	return e.Reason
-}
-
 var _ error = (*RoutingInvalid)(nil)
 var _ error = (*ServiceConflictError)(nil)
 

controllers/controller/devworkspacerouting/solvers/solver.go

@@ -103,7 +103,7 @@ func (_ *SolverGetter) HasSolver(routingClass controllerv1alpha1.DevWorkspaceRou
 
 func (_ *SolverGetter) GetSolver(client client.Client, logger logr.Logger, routingClass controllerv1alpha1.DevWorkspaceRoutingClass) (RoutingSolver, error) {
 	isOpenShift := infrastructure.IsOpenShift()
-	
+
 	switch routingClass {
 	case controllerv1alpha1.DevWorkspaceRoutingBasic:
 		return NewBasicSolver(client, logger), nil

controllers/controller/devworkspacerouting/sync_ingresses.go

@@ -19,7 +19,6 @@ import (
 	"context"
 	"fmt"
 
-	"github.com/devfile/devworkspace-operator/controllers/controller/devworkspacerouting/solvers"
 	"github.com/devfile/devworkspace-operator/pkg/constants"
 	"github.com/devfile/devworkspace-operator/pkg/provision/sync"
 
@@ -33,14 +32,6 @@ import (
 func (r *DevWorkspaceRoutingReconciler) syncIngresses(routing *controllerv1alpha1.DevWorkspaceRouting, specIngresses []networkingv1.Ingress) (ok bool, clusterIngresses []networkingv1.Ingress, err error) {
 	ingressesInSync := true
 
-	for _, ingress := range specIngresses {
-		for _, rule := range ingress.Spec.Rules {
-			if err := r.checkForIngressConflict(rule.Host, routing); err != nil {
-				return false, nil, err
-			}
-		}
-	}
-
 	clusterIngresses, err = r.getClusterIngresses(routing)
 	if err != nil {
 		return false, nil, err
@@ -99,28 +90,6 @@ func (r *DevWorkspaceRoutingReconciler) getClusterIngresses(routing *controllerv
 	return found.Items, nil
 }
 
-func (r *DevWorkspaceRoutingReconciler) checkForIngressConflict(hostname string, owner *controllerv1alpha1.DevWorkspaceRouting) error {
-	ingresses := &networkingv1.IngressList{}
-	if err := r.List(context.TODO(), ingresses, client.InNamespace(owner.Namespace)); err != nil {
-		return err
-	}
-	for _, ingress := range ingresses.Items {
-		for _, rule := range ingress.Spec.Rules {
-			if rule.Host == hostname {
-				for _, ownerRef := range ingress.GetOwnerReferences() {
-					if ownerRef.UID == owner.UID {
-						return nil
-					}
-				}
-				return &solvers.HostnameConflictError{
-					Reason: fmt.Sprintf("hostname %s is already in use by ingress %s", hostname, ingress.Name),
-				}
-			}
-		}
-	}
-	return nil
-}
-
 func getIngressesToDelete(clusterIngresses, specIngresses []networkingv1.Ingress) []networkingv1.Ingress {
 	var toDelete []networkingv1.Ingress
 	for _, clusterIngress := range clusterIngresses {

controllers/controller/devworkspacerouting/sync_routes.go

@@ -19,7 +19,6 @@ import (
 	"context"
 	"fmt"
 
-	"github.com/devfile/devworkspace-operator/controllers/controller/devworkspacerouting/solvers"
 	"github.com/devfile/devworkspace-operator/pkg/constants"
 	"github.com/devfile/devworkspace-operator/pkg/provision/sync"
 	routeV1 "github.com/openshift/api/route/v1"
@@ -32,12 +31,6 @@ import (
 func (r *DevWorkspaceRoutingReconciler) syncRoutes(routing *controllerv1alpha1.DevWorkspaceRouting, specRoutes []routeV1.Route) (ok bool, clusterRoutes []routeV1.Route, err error) {
 	routesInSync := true
 
-	for _, route := range specRoutes {
-		if err := r.checkForRouteConflict(route.Spec.Host, routing); err != nil {
-			return false, nil, err
-		}
-	}
-
 	clusterRoutes, err = r.getClusterRoutes(routing)
 	if err != nil {
 		return false, nil, err
@@ -107,26 +100,6 @@ func (r *DevWorkspaceRoutingReconciler) getClusterRoutes(routing *controllerv1al
 	return routes, nil
 }
 
-func (r *DevWorkspaceRoutingReconciler) checkForRouteConflict(hostname string, owner *controllerv1alpha1.DevWorkspaceRouting) error {
-	routes := &routeV1.RouteList{}
-	if err := r.List(context.TODO(), routes, client.InNamespace(owner.Namespace)); err != nil {
-		return err
-	}
-	for _, route := range routes.Items {
-		if route.Spec.Host == hostname {
-			for _, ownerRef := range route.GetOwnerReferences() {
-				if ownerRef.UID == owner.UID {
-					return nil
-				}
-			}
-			return &solvers.HostnameConflictError{
-				Reason: fmt.Sprintf("hostname %s is already in use by route %s", hostname, route.Name),
-			}
-		}
-	}
-	return nil
-}
-
 func getRoutesToDelete(clusterRoutes, specRoutes []routeV1.Route) []routeV1.Route {
 	var toDelete []routeV1.Route
 	for _, clusterRoute := range clusterRoutes {