Skip to content

Commit 290ff4e

Browse files
committed
Merge branch 'next' of github.com:devforth/adminforth into next
2 parents b2972c7 + 969eb52 commit 290ff4e

File tree

3 files changed

+17
-6
lines changed

3 files changed

+17
-6
lines changed

adminforth/spa/src/components/MenuLink.vue

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,19 +12,20 @@
1212
>
1313
<component v-if="item.icon" :is="getIcon(item.icon)" class="w-5 h-5 text-lightSidebarIcons dark:text-darkSidebarIcons transition duration-75 group-hover:text-lightSidebarIconsHover dark:group-hover:text-darkSidebarIconsHover" ></component>
1414
<span class="text-ellipsis overflow-hidden ms-3">{{ item.label }}</span>
15-
<span v-if="item.badge" class="inline-flex items-center justify-center h-3 py-3 px-1 ms-3 text-sm font-medium rounded-full bg-lightAnnouncementBG dark:bg-darkAnnouncementBG
16-
fill-lightAnnouncementText dark:fill-darkAccent text-lightAnnouncementText dark:text-darkAccent min-w-[1.5rem] max-w-[3rem]"
15+
<span v-if="item.badge"
1716
>
1817

1918
<Tooltip v-if="item.badgeTooltip">
20-
{{ item.badge }}
19+
<div class="inline-flex items-center justify-center h-3 py-3 px-1 ms-3 text-sm font-medium rounded-full bg-lightAnnouncementBG dark:bg-darkAnnouncementBG
20+
fill-lightAnnouncementText dark:fill-darkAccent text-lightAnnouncementText dark:text-darkAccent min-w-[1.5rem] max-w-[3rem]">{{ item.badge }}</div>
2121

2222
<template #tooltip>
2323
{{ item.badgeTooltip }}
2424
</template>
2525
</Tooltip>
2626
<template v-else>
27-
{{ item.badge }}
27+
<div class="inline-flex items-center justify-center h-3 py-3 px-1 ms-3 text-sm font-medium rounded-full bg-lightAnnouncementBG dark:bg-darkAnnouncementBG
28+
fill-lightAnnouncementText dark:fill-darkAccent text-lightAnnouncementText dark:text-darkAccent min-w-[1.5rem] max-w-[3rem]">{{ item.badge }}</div>
2829
</template>
2930

3031
</span>

adminforth/spa/src/stores/core.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,9 @@ export const useCoreStore = defineStore('core', () => {
8686
}
8787
async function subscribeToMenuBadges() {
8888
const processItem = (mi: AdminForthConfigMenuItem) => {
89-
if (mi.badge) {
89+
90+
// console.log('🔔 subscribeToMenuBadges', mi.badge, JSON.stringify(mi));
91+
if (mi.badge !== undefined) {
9092
websocket.subscribe(`/opentopic/update-menu-badge/${mi.itemId}`, ({ badge }) => {
9193
mi.badge = badge;
9294
});

adminforth/spa/src/views/EditView.vue

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,15 @@ async function saveRecord() {
147147
saving.value = true;
148148
const updates = {};
149149
for (const key in record.value) {
150-
let columnIsUpdated = record.value[key] !== coreStore.record[key];
150+
let columnIsUpdated = false;
151+
152+
if (typeof record.value[key] !== typeof coreStore.record[key]) {
153+
columnIsUpdated = true;
154+
} else if (typeof record.value[key] === 'object') {
155+
columnIsUpdated = JSON.stringify(record.value[key]) !== JSON.stringify(coreStore.record[key]);
156+
} else {
157+
columnIsUpdated = record.value[key] !== coreStore.record[key];
158+
}
151159
152160
const column = coreStore.resource.columns.find((c) => c.name === key);
153161

0 commit comments

Comments
 (0)