Skip to content

Commit b3ec9be

Browse files
committed
fix: allo to not pass any arguments to count
1 parent 6698457 commit b3ec9be

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

adminforth/dataConnectors/sqlite.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,7 @@ class SQLiteConnector extends AdminForthBaseConnector implements IAdminForthData
263263
console.log('🪲📜 SQLITE Q', q, 'params:', filterValues);
264264
}
265265
const totalStmt = this.client.prepare(q);
266-
return totalStmt.get([...filterValues])['COUNT(*)'];
266+
return +totalStmt.get([...filterValues])['COUNT(*)'];
267267
}
268268

269269
async getMinMaxForColumnsWithOriginalTypes({ resource, columns }: { resource: AdminForthResource, columns: AdminForthResourceColumn[] }): Promise<{ [key: string]: { min: any, max: any } }> {

adminforth/modules/operationalResource.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ export default class OperationalResource implements IOperationalResource {
6161
}
6262

6363

64-
async count(filter: IAdminForthSingleFilter | IAdminForthAndOrFilter | Array<IAdminForthSingleFilter | IAdminForthAndOrFilter> | undefined): Promise<number> {
64+
async count(filter?: IAdminForthSingleFilter | IAdminForthAndOrFilter | Array<IAdminForthSingleFilter | IAdminForthAndOrFilter> | undefined): Promise<number> {
6565
return await this.dataConnector.getCount({
6666
resource: this.resourceConfig,
6767
filters: this.dataConnector.validateAndNormalizeInputFilters(filter),

adminforth/types/Back.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1124,7 +1124,7 @@ export interface IOperationalResource {
11241124

11251125
list: (filter: IAdminForthSingleFilter | IAdminForthAndOrFilter | Array<IAdminForthSingleFilter | IAdminForthAndOrFilter>, limit?: number, offset?: number, sort?: IAdminForthSort | IAdminForthSort[]) => Promise<any[]>;
11261126

1127-
count: (filter: IAdminForthSingleFilter | IAdminForthAndOrFilter | Array<IAdminForthSingleFilter | IAdminForthAndOrFilter> | undefined) => Promise<number>;
1127+
count: (filter?: IAdminForthSingleFilter | IAdminForthAndOrFilter | Array<IAdminForthSingleFilter | IAdminForthAndOrFilter>) => Promise<number>;
11281128

11291129
create: (record: any) => Promise<{ ok: boolean; createdRecord: any; error?: string; }>;
11301130

0 commit comments

Comments
 (0)