Skip to content

Commit c8d5183

Browse files
committed
LibWeb/Crypto: Remove RSA-PSS key import FIXMEs after spec fix
1 parent ee59988 commit c8d5183

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

Libraries/LibWeb/Crypto/CryptoAlgorithms.cpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1564,12 +1564,10 @@ WebIDL::ExceptionOr<GC::Ref<CryptoKey>> RSAPSS::import_key(AlgorithmParams const
15641564
if (!meets_requirements)
15651565
return WebIDL::DataError::create(m_realm, "Invalid JWK private key"_string);
15661566

1567-
// FIXME: Spec error, it should say 'the RSA private key identified by interpreting jwk according to section 6.3.2'
1568-
// 2. Let privateKey represent the RSA public key identified by interpreting jwk according to Section 6.3.1 of JSON Web Algorithms [JWA].
1567+
// 2. Let privateKey represent the RSA private key identified by interpreting jwk according to Section 6.3.2 of JSON Web Algorithms [JWA].
15691568
auto private_key = TRY(parse_jwk_rsa_private_key(realm, jwk));
15701569

1571-
// FIXME: Spec error, it should say 'not to be a valid RSA private key'
1572-
// 3. If privateKey can be determined to not be a valid RSA public key according to [RFC3447], then throw a DataError.
1570+
// 3. If privateKey can be determined to not be a valid RSA private key according to [RFC3447], then throw a DataError.
15731571
auto maybe_valid = private_key.is_valid();
15741572
if (maybe_valid.is_error())
15751573
return WebIDL::DataError::create(m_realm, "Failed to verify key"_string);

0 commit comments

Comments
 (0)