filter out nodeinfo properties that are used for configuration in the serialize cleanup method

Author: devhelpr

libs/visual-programming-system/src/types/base-node-info.ts

@@ -69,37 +69,70 @@ export interface INodeDecorator {
   };
 }
 
-export interface BaseNodeInfo {
-  taskType?: string;
-  type?: string;
-  compositionId?: string;
-  isComposition?: boolean;
+// These also contain properties from NodeInfo (which is a superset of BaseNodeInfo)..
+// TODO : move that and have some sort of registration construction so that it can be
+//   used dynamically by the serialization proces
+export interface BaseSettingsNodeInfo {
   useInCompositionOnly?: boolean;
   nodeCannotBeReplaced?: boolean;
   isAnnotation?: boolean;
   canBeStartedByTrigger?: boolean;
   readPropertyFromNodeInfoForInitialTrigger?: string;
   keepPopupOpenAfterUpdate?: boolean;
   supportsPreview?: boolean;
+  showFormOnlyInPopup?: boolean;
+  isSettingsPopup?: boolean;
+  hasNoFormPopup?: boolean;
+  meta?: AllMetaFieldTypes[];
+  metaInputs?: AllMetaFieldTypes[];
+  canvasAppInstance?: IFlowCanvasBase<BaseNodeInfo>;
+  initializeOnStartFlow?: boolean;
+  isVariable?: boolean;
+  isUINode?: boolean;
+  supportsDecorators?: boolean;
+}
+const baseSettingsNodeInfoSchema: Record<keyof BaseSettingsNodeInfo, boolean> =
+  {
+    useInCompositionOnly: true,
+    nodeCannotBeReplaced: true,
+    isAnnotation: true,
+    canBeStartedByTrigger: true,
+    readPropertyFromNodeInfoForInitialTrigger: true,
+    keepPopupOpenAfterUpdate: true,
+    supportsPreview: true,
+    showFormOnlyInPopup: true,
+    isSettingsPopup: true,
+    hasNoFormPopup: true,
+    meta: true,
+    metaInputs: true,
+    canvasAppInstance: true,
+    initializeOnStartFlow: true,
+    isVariable: true,
+    isUINode: true,
+    supportsDecorators: true,
+  };
+
+export const baseSettingsNodeInfoProperties = Object.keys(
+  baseSettingsNodeInfoSchema
+) as (keyof BaseSettingsNodeInfo)[];
+
+export interface BaseNodeInfo extends BaseSettingsNodeInfo {
+  taskType?: string;
+  type?: string;
+  compositionId?: string;
+  isComposition?: boolean;
   cancelPreview?: () => void;
   outputConnectionInfo?: {
     text: string;
     fieldName: string;
     form?: any[];
     onChanged?: (connection: IConnectionNodeComponent<BaseNodeInfo>) => void;
   };
-  canvasAppInstance?: IFlowCanvasBase<BaseNodeInfo>;
 
   initializeCompute?: () => void;
-  showFormOnlyInPopup?: boolean;
-  isSettingsPopup?: boolean;
-  hasNoFormPopup?: boolean;
   formElements?: any[];
   delete?: () => void;
   formValues?: any;
   decorators?: INodeDecorator[];
   update?: () => void;
-
-  meta?: AllMetaFieldTypes[];
-  metaInputs?: AllMetaFieldTypes[];
 }

libs/visual-programming-system/src/utils/serialize.ts

@@ -3,7 +3,10 @@ import {
   IConnectionNodeComponent,
   IRectNodeComponent,
 } from '../interfaces';
-import { BaseNodeInfo } from '../types/base-node-info';
+import {
+  BaseNodeInfo,
+  baseSettingsNodeInfoProperties,
+} from '../types/base-node-info';
 
 export const cleanupNodeInfoForSerializing = <T extends BaseNodeInfo>(
   nodeInfo: T | undefined
@@ -12,6 +15,7 @@ export const cleanupNodeInfoForSerializing = <T extends BaseNodeInfo>(
   if (nodeInfo) {
     for (const key in nodeInfo) {
       if (
+        !baseSettingsNodeInfoProperties.find((item) => item === key) &&
         typeof (nodeInfo as any)[key] !== 'function' &&
         key !== 'formElements' &&
         key !== 'canvasAppInstance' &&