Skip to content

Commit 2513d82

Browse files
Exclude the discriminator field from getting a nullable_var_annotations (OpenAPITools#21155)
* Exclude the discriminator field from getting a nullable_var_annotations * Update samples * Manually add annotations since the remote pipeline insists that they should be there * Add description for why the discriminator does not have a nullability-annotation * Update samples
1 parent 6c31cbb commit 2513d82

File tree

17 files changed

+21
-16
lines changed

17 files changed

+21
-16
lines changed

modules/openapi-generator/src/main/resources/Java/pojo.mustache

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,12 @@ public class {{classname}} {{#parent}}extends {{{.}}} {{/parent}}{{#vendorExtens
6767
{{#gson}}
6868
@SerializedName(SERIALIZED_NAME_{{nameInSnakeCase}})
6969
{{/gson}}
70+
{{^isDiscriminator}}
7071
{{>nullable_var_annotations}}{{! prevent indent}}
72+
{{/isDiscriminator}}
73+
{{#isDiscriminator}}
74+
// The discriminator does not have Nullability-annotation since it is added during serialization by the @JsonTypeName annotation
75+
{{/isDiscriminator}}
7176
{{#vendorExtensions.x-field-extra-annotation}}
7277
{{{vendorExtensions.x-field-extra-annotation}}}
7378
{{/vendorExtensions.x-field-extra-annotation}}

samples/client/petstore/java/apache-httpclient/src/main/java/org/openapitools/client/model/Animal.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@
4949

5050
public class Animal {
5151
public static final String JSON_PROPERTY_CLASS_NAME = "className";
52-
@javax.annotation.Nonnull
52+
// The discriminator does not have Nullability-annotation since it is added during serialization by the @JsonTypeName annotation
5353
protected String className;
5454

5555
public static final String JSON_PROPERTY_COLOR = "color";

samples/client/petstore/java/apache-httpclient/src/main/java/org/openapitools/client/model/ParentWithNullable.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ public static TypeEnum fromValue(String value) {
8585
}
8686

8787
public static final String JSON_PROPERTY_TYPE = "type";
88-
@javax.annotation.Nullable
88+
// The discriminator does not have Nullability-annotation since it is added during serialization by the @JsonTypeName annotation
8989
protected TypeEnum type;
9090

9191
public static final String JSON_PROPERTY_NULLABLE_PROPERTY = "nullableProperty";

samples/client/petstore/java/google-api-client/src/main/java/org/openapitools/client/model/Animal.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@
4747

4848
public class Animal {
4949
public static final String JSON_PROPERTY_CLASS_NAME = "className";
50-
@javax.annotation.Nonnull
50+
// The discriminator does not have Nullability-annotation since it is added during serialization by the @JsonTypeName annotation
5151
protected String className;
5252

5353
public static final String JSON_PROPERTY_COLOR = "color";

samples/client/petstore/java/rest-assured-jackson/src/main/java/org/openapitools/client/model/Animal.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@
5050

5151
public class Animal {
5252
public static final String JSON_PROPERTY_CLASS_NAME = "className";
53-
@javax.annotation.Nonnull
53+
// The discriminator does not have Nullability-annotation since it is added during serialization by the @JsonTypeName annotation
5454
protected String className;
5555

5656
public static final String JSON_PROPERTY_COLOR = "color";

samples/client/petstore/java/rest-assured/src/main/java/org/openapitools/client/model/Animal.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
public class Animal {
3333
public static final String SERIALIZED_NAME_CLASS_NAME = "className";
3434
@SerializedName(SERIALIZED_NAME_CLASS_NAME)
35-
@javax.annotation.Nonnull
35+
// The discriminator does not have Nullability-annotation since it is added during serialization by the @JsonTypeName annotation
3636
protected String className;
3737

3838
public static final String SERIALIZED_NAME_COLOR = "color";

samples/client/petstore/java/resteasy/src/main/java/org/openapitools/client/model/Animal.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@
4646

4747
public class Animal {
4848
public static final String JSON_PROPERTY_CLASS_NAME = "className";
49-
@javax.annotation.Nonnull
49+
// The discriminator does not have Nullability-annotation since it is added during serialization by the @JsonTypeName annotation
5050
protected String className;
5151

5252
public static final String JSON_PROPERTY_COLOR = "color";

samples/client/petstore/java/resteasy/src/main/java/org/openapitools/client/model/ParentWithNullable.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ public static TypeEnum fromValue(String value) {
8282
}
8383

8484
public static final String JSON_PROPERTY_TYPE = "type";
85-
@javax.annotation.Nullable
85+
// The discriminator does not have Nullability-annotation since it is added during serialization by the @JsonTypeName annotation
8686
protected TypeEnum type;
8787

8888
public static final String JSON_PROPERTY_NULLABLE_PROPERTY = "nullableProperty";

samples/client/petstore/java/retrofit2-play26/src/main/java/org/openapitools/client/model/Animal.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@
4949

5050
public class Animal {
5151
public static final String JSON_PROPERTY_CLASS_NAME = "className";
52-
@jakarta.annotation.Nonnull
52+
// The discriminator does not have Nullability-annotation since it is added during serialization by the @JsonTypeName annotation
5353
protected String className;
5454

5555
public static final String JSON_PROPERTY_COLOR = "color";

samples/client/petstore/java/retrofit2/src/main/java/org/openapitools/client/model/Animal.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
public class Animal {
3030
public static final String SERIALIZED_NAME_CLASS_NAME = "className";
3131
@SerializedName(SERIALIZED_NAME_CLASS_NAME)
32-
@javax.annotation.Nonnull
32+
// The discriminator does not have Nullability-annotation since it is added during serialization by the @JsonTypeName annotation
3333
protected String className;
3434

3535
public static final String SERIALIZED_NAME_COLOR = "color";

0 commit comments

Comments
 (0)