allow step names to be empty

Author: michaelst

internal/provider/devhub_workflow_resource.go

@@ -298,8 +298,10 @@ func (r *workflowResource) Create(ctx context.Context, req resource.CreateReques
 
 	var steps []devhub.WorkflowStep
 	for _, step := range plan.Steps {
-		workflowStep := devhub.WorkflowStep{
-			Name: step.Name.ValueString(),
+		workflowStep := devhub.WorkflowStep{}
+
+		if step.Name.ValueString() != "" {
+			workflowStep.Name = step.Name.ValueString()
 		}
 
 		if step.ApiAction != nil {
@@ -439,8 +441,11 @@ func (r *workflowResource) Read(ctx context.Context, req resource.ReadRequest, r
 	var stateSteps []workflowStepModel
 	for _, step := range workflow.Steps {
 		stepModel := workflowStepModel{
-			Id:   types.StringValue(step.Id),
-			Name: types.StringValue(step.Name),
+			Id: types.StringValue(step.Id),
+		}
+
+		if step.Name != "" {
+			stepModel.Name = types.StringValue(step.Name)
 		}
 
 		switch step.Action.Type {
@@ -524,8 +529,11 @@ func (r *workflowResource) Update(ctx context.Context, req resource.UpdateReques
 	var steps []devhub.WorkflowStep
 	for _, step := range plan.Steps {
 		workflowStep := devhub.WorkflowStep{
-			Id:   step.Id.ValueString(),
-			Name: step.Name.ValueString(),
+			Id: step.Id.ValueString(),
+		}
+
+		if step.Name.ValueString() != "" {
+			workflowStep.Name = step.Name.ValueString()
 		}
 
 		if step.ApiAction != nil {

internal/provider/devhub_workflow_resource_test.go

@@ -37,7 +37,6 @@ func TestAccWorkflowResource(t *testing.T) {
 					resource.TestCheckResourceAttr("devhub_workflow.test", "steps.3.slack_action.slack_channel", "#general"),
 					resource.TestCheckResourceAttr("devhub_workflow.test", "steps.3.slack_action.message", "Hello, world!"),
 					resource.TestCheckResourceAttr("devhub_workflow.test", "steps.3.slack_action.link_text", "Click here"),
-					resource.TestCheckResourceAttr("devhub_workflow.test", "steps.4.name", "slack-reply-step"),
 					resource.TestCheckResourceAttr("devhub_workflow.test", "steps.4.slack_reply_action.reply_to_step_name", "slack-step"),
 					resource.TestCheckResourceAttr("devhub_workflow.test", "steps.4.slack_reply_action.message", "Hello, world!"),
 					resource.TestCheckResourceAttrSet("devhub_workflow.test", "id"),
@@ -78,7 +77,6 @@ func TestAccWorkflowResource(t *testing.T) {
 					resource.TestCheckResourceAttr("devhub_workflow.test", "steps.3.slack_action.slack_channel", "#general"),
 					resource.TestCheckResourceAttr("devhub_workflow.test", "steps.3.slack_action.message", "Hello, world!"),
 					resource.TestCheckResourceAttr("devhub_workflow.test", "steps.3.slack_action.link_text", "Click here"),
-					resource.TestCheckResourceAttr("devhub_workflow.test", "steps.4.name", "slack-reply-step"),
 					resource.TestCheckResourceAttr("devhub_workflow.test", "steps.4.slack_reply_action.reply_to_step_name", "slack-step"),
 					resource.TestCheckResourceAttr("devhub_workflow.test", "steps.4.slack_reply_action.message", "Hello, world!"),
 					resource.TestCheckResourceAttrSet("devhub_workflow.test", "id"),
@@ -140,7 +138,6 @@ resource "devhub_workflow" "test" {
 			}
 		},
 		{
-			name = "slack-reply-step"
 			slack_reply_action = {
 				reply_to_step_name = "slack-step"
 				message = "Hello, world!"