test: remove redundant test/assertion in Handler/DateFormatInterfaceHandlerTest (#216)

Co-authored-by: Claude <[email protected]>

Author: deviantintegral

tests/src/Unit/Handler/DateFormatInterfaceHandlerTest.php

@@ -24,7 +24,6 @@ protected function setUp(): void
     public function testGetSubscribingMethods(): void
     {
         $methods = DateFormatInterfaceHandler::getSubscribingMethods();
-        $this->assertIsArray($methods); // @phpstan-ignore method.alreadyNarrowedType
         $this->assertNotEmpty($methods);
 
         // Check that all expected types are present
@@ -47,18 +46,6 @@ public function testGetSubscribingMethods(): void
         $this->assertContains(GraphNavigatorInterface::DIRECTION_DESERIALIZATION, $directions);
     }
 
-    public function testConstructorWithDefaultParameters(): void
-    {
-        $handler = new DateFormatInterfaceHandler();
-        $this->assertInstanceOf(DateFormatInterfaceHandler::class, $handler);
-    }
-
-    public function testConstructorWithCustomParameters(): void
-    {
-        $handler = new DateFormatInterfaceHandler('Y-m-d', 'America/New_York');
-        $this->assertInstanceOf(DateFormatInterfaceHandler::class, $handler);
-    }
-
     public function testSerializeNullDateTime(): void
     {
         $nullDateTime = new NullDateTime();
@@ -85,18 +72,6 @@ public function testDeserializeNullOrEmptyStringReturnsNullDateTime(): void
         $this->assertInstanceOf(NullDateTime::class, $result->getExpires());
     }
 
-    public function testDeserializeEmptyStringReturnsNullDateTime(): void
-    {
-        // Test using the actual serializer to deserialize a Cookie with empty string expires datetime
-        $serializer = new \Deviantintegral\Har\Serializer();
-
-        $json = '{"name": "test", "value": "value", "expires": ""}';
-        $result = $serializer->getSerializer()->deserialize($json, \Deviantintegral\Har\Cookie::class, 'json');
-
-        $this->assertInstanceOf(\Deviantintegral\Har\Cookie::class, $result);
-        $this->assertInstanceOf(NullDateTime::class, $result->getExpires());
-    }
-
     public function testDeserializeValidDateTimeReturnsConcreteDateTime(): void
     {
         // Test using the actual serializer to deserialize a Cookie with valid expires datetime
@@ -107,30 +82,5 @@ public function testDeserializeValidDateTimeReturnsConcreteDateTime(): void
 
         $this->assertInstanceOf(\Deviantintegral\Har\Cookie::class, $result);
         $this->assertInstanceOf(\Deviantintegral\NullDateTime\ConcreteDateTime::class, $result->getExpires());
-        $this->assertNotInstanceOf(NullDateTime::class, $result->getExpires());
-    }
-
-    public function testDeserializeLogicalOrCondition(): void
-    {
-        // This test kills Identical and LogicalOr mutations by verifying the exact behavior
-        // of the condition: if (null === $data || '' === $data)
-        $serializer = new \Deviantintegral\Har\Serializer();
-
-        // Test empty string - should return NullDateTime
-        $jsonEmpty = '{"name": "test", "value": "value", "expires": ""}';
-        $resultEmpty = $serializer->getSerializer()->deserialize($jsonEmpty, \Deviantintegral\Har\Cookie::class, 'json');
-        $this->assertInstanceOf(NullDateTime::class, $resultEmpty->getExpires(), 'Empty string should return NullDateTime');
-
-        // Test valid datetime - should NOT return NullDateTime
-        $jsonValid = '{"name": "test", "value": "value", "expires": "2023-01-15T10:30:00.000Z"}';
-        $resultValid = $serializer->getSerializer()->deserialize($jsonValid, \Deviantintegral\Har\Cookie::class, 'json');
-        $this->assertNotInstanceOf(NullDateTime::class, $resultValid->getExpires(), 'Valid datetime should NOT return NullDateTime');
-        $this->assertInstanceOf(\Deviantintegral\NullDateTime\ConcreteDateTime::class, $resultValid->getExpires());
-
-        // This test specifically kills these mutants:
-        // 1. Identical: if (null !== $data || '' === $data)
-        //    Would cause empty string to try parsing as datetime (error) instead of returning NullDateTime
-        // 2. LogicalOrAllSubExprNegation: if (!(null === $data) || !('' === $data))
-        //    Would be true for valid strings, incorrectly returning NullDateTime for valid dates
     }
 }