chore: upgrade symfony/console to ^7||^8 #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deviantintegral
changed the title
This upgrade brings the project up to date with the latest Symfony Console versions. Changes include: - Updated composer.json to require symfony/console ^7||^8 - Added return type declaration and return statement to SplitCommand::execute() for Symfony Console 7/8 compatibility
This commit adds comprehensive functional tests for the har:split console command covering: - Splitting multi-entry HAR files - Splitting single-entry HAR files - MD5 filename option - Force overwrite option - Error handling when files exist without force flag - Default to current directory behavior - HAR structure preservation Also fixed Symfony Console 8 compatibility: - Added void return type to SplitCommand::configure() Updated phpunit.xml.dist to include Functional test suite. Tests: 53, Assertions: 204
- Reverted phpunit.xml.dist to PHPUnit 9.3 schema (compatible with PHPUnit 9.6) - Changed HarTest to use @dataProvider docblock instead of PHP 8 attributes - Changed fixtureDataProvider from static to instance method The rebase introduced PHPUnit 12.5 schema and PHP 8 attribute syntax which are not compatible with the current PHPUnit 9.6 version used in the project.
deviantintegral
force-pushed
the
claude/upgrade-symfony-console-1Y8LB
branch
from
f861eb6 to
2db1176
Compare
Changed mkdir() call to use default permissions instead of 0777. The 0777 mode made directories world-writable, which is a security concern. Now using system umask defaults (typically 0755 or 0700).
- Restored PHPUnit 12.5 schema in phpunit.xml.dist - Restored PHP 8 attribute syntax for data providers in HarTest - Simplified phpunit.xml.dist configuration for better compatibility - All 53 tests pass with 204 assertions PHPUnit upgraded from 9.6 to 12.5.3 via composer.json requirement.
- Fixed string concatenation spacing (removed spaces around .) - Changed post-increment to pre-increment (++$i) - Escaped count() function as \count()
Fixes PHP 8.4 deprecation: 'Implicitly marking parameter $text as nullable is deprecated, the explicit nullable type must be used instead' Changed from: setText(string $text = null) To: setText(?string $text = null)
deviantintegral
added a commit
that referenced
this pull request
Dec 14, 2025
🤖 I have created a release *beep* *boop* --- ## [0.4.0](0.3.0...v0.4.0) (2025-12-14) ### Features * add pre-commit hooks for php-cs-fixer and phpunit ([#109](#109)) ([80a12c4](80a12c4)) * add support for PSR-7 ServerRequest ([#108](#108)) ([7df2364](7df2364)) * drop support for PHP 8.0 and 8.1 ([#104](#104)) ([2241b8d](2241b8d)) ### Bug Fixes * set release-please manifest version to 0.4.0 ([72ccbee](72ccbee)) ### Miscellaneous Chores * **config:** migrate Renovate config ([#98](#98)) ([83d168d](83d168d)) * **deps:** update actions/upload-artifact action to v6 ([#107](#107)) ([54c890a](54c890a)) * fix nullable param deprecation ([#110](#110)) ([79ced46](79ced46)) * upgrade PHPUnit to ^11||^12 ([#106](#106)) ([4617172](4617172)) * upgrade symfony/console to ^7||^8 ([#105](#105)) ([4002a2c](4002a2c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrade brings the project up to date with the latest Symfony Console versions. Changes include: