Skip to content

Commit c0da80b

Browse files
Merge pull request #12 from cscaglioned42/master
D42-30527 - GitHub Jamf - Not all device fields being sent are getting saved in D42 Fixed issue where D42 would not be able to add/update a device if a None value was sent.
2 parents 434a0a5 + 388d6ad commit c0da80b

File tree

1 file changed

+9
-3
lines changed

1 file changed

+9
-3
lines changed

starter.py

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,17 +54,23 @@ def get_computers(self):
5454
'hddcount': hdd_count,
5555
'hddsize': hdd_size,
5656
'uuid': general['udid'] if general['udid'] else None,
57-
'serial_no': general['serial_number'] if general['serial_number'] else None,
5857
'hardware': hardware['model'] if hardware['model'] else None,
5958
'os': hardware['os_name'] if hardware['os_name'] else None,
6059
'osver': hardware['os_version'] if hardware['os_version'] else None,
6160
'memory': hardware['total_ram_mb'] if hardware['total_ram_mb'] else None,
6261
'cpucount': hardware['number_processors'] if hardware['number_processors'] else None,
63-
'cpupower': hardware['processor_speed_mhz'] if hardware['processor_speed_mhz'] else None,
64-
'cpucore': hardware['number_cores'] if hardware['number_cores'] else None,
6562
'tags': general['asset_tag'] if general['asset_tag'] else None
6663
})
6764

65+
if general['serial_number']:
66+
device['serial_no'] = general['serial_number']
67+
68+
if hardware['processor_speed_mhz']:
69+
device['cpupower'] = hardware['processor_speed_mhz']
70+
71+
if hardware['number_cores']:
72+
device['cpucore'] = hardware['number_cores']
73+
6874
devices.append({
6975
'device': {k: v for (k, v) in device.items() if str(v) != str(-1)},
7076
'general': general,

0 commit comments

Comments
 (0)