escape special chars

Author: riglar

dist/index.js

@@ -32533,6 +32533,10 @@ Object.defineProperty(exports, "__esModule", ({ value: true }));
 const core_1 = __nccwpck_require__(2186);
 const params_1 = __nccwpck_require__(5966);
 const child_process_1 = __nccwpck_require__(2081);
+const escapeShellValue = (value) => {
+    // Escape special characters that could cause shell interpretation issues
+    return value.replace(/(["\\'$`!])/g, '\\$1');
+};
 const run = () => __awaiter(void 0, void 0, void 0, function* () {
     try {
         const { additionalAppBinaryIds, additionalAppFiles, androidApiLevel, androidDevice, apiKey, apiUrl, appBinaryId, appFilePath, async, deviceLocale, downloadArtifacts, env, excludeFlows, excludeTags, googlePlay, includeTags, iOSVersion, iosDevice, maestroVersion, name, orientation, retry, workspaceFolder, } = yield (0, params_1.getParameters)();
@@ -32563,16 +32567,21 @@ const run = () => __awaiter(void 0, void 0, void 0, function* () {
         let paramsString = Object.keys(params).reduce((acc, key) => {
             if (!params[key])
                 return acc;
-            const needsQuotes = typeof params[key] === 'string' &&
-                '"' !== params[key][0] &&
-                params[key].includes(' ');
-            const value = needsQuotes ? `"${params[key]}"` : params[key];
-            return `${acc} --${key} ${value}`;
+            const value = typeof params[key] === 'string'
+                ? escapeShellValue(params[key])
+                : params[key];
+            const needsQuotes = typeof value === 'string' &&
+                !value.startsWith('"') &&
+                (value.includes(' ') || value.includes('\\'));
+            const finalValue = needsQuotes ? `"${value}"` : value;
+            return `${acc} --${key} ${finalValue}`;
         }, '');
         if (env && env.length > 0) {
             env.forEach((e) => {
                 let [key, value] = e.split('=');
-                const needsQuotes = '"' !== value[0] && value.includes(' ');
+                value = escapeShellValue(value);
+                const needsQuotes = !value.startsWith('"') &&
+                    (value.includes(' ') || value.includes('\\'));
                 if (needsQuotes)
                     value = `"${value}"`;
                 paramsString += ` --env ${key}=${value}`;

package.json

@@ -2,7 +2,7 @@
   "name": "dcd-github-action",
   "description": "run maestro tests on devicecloud.dev",
   "author": "devicecloud.dev",
-  "version": "1.2.0",
+  "version": "1.2.1",
   "main": "src/index.ts",
   "license": "MIT",
   "engines": {
@@ -24,5 +24,6 @@
     "@types/node-fetch": "^2.6.4",
     "@vercel/ncc": "^0.36.1",
     "typescript": "^5.1.6"
-  }
+  },
+  "packageManager": "[email protected]+sha512.a6b2f7906b721bba3d67d4aff083df04dad64c399707841b7acf00f6b133b7ac24255f2652fa22ae3534329dc6180534e98d17432037ff6fd140556e2bb3137e"
 }

src/index.ts

@@ -2,6 +2,11 @@ import { setFailed } from '@actions/core';
 import { getParameters } from './methods/params';
 import { execSync } from 'child_process';
 
+const escapeShellValue = (value: string): string => {
+  // Escape special characters that could cause shell interpretation issues
+  return value.replace(/(["\\'$`!])/g, '\\$1');
+};
+
 const run = async (): Promise<void> => {
   try {
     const {
@@ -57,18 +62,25 @@ const run = async (): Promise<void> => {
 
     let paramsString = Object.keys(params).reduce((acc, key) => {
       if (!params[key]) return acc;
+      const value =
+        typeof params[key] === 'string'
+          ? escapeShellValue(params[key])
+          : params[key];
       const needsQuotes =
-        typeof params[key] === 'string' &&
-        '"' !== params[key][0] &&
-        params[key].includes(' ');
-      const value = needsQuotes ? `"${params[key]}"` : params[key];
-      return `${acc} --${key} ${value}`;
+        typeof value === 'string' &&
+        !value.startsWith('"') &&
+        (value.includes(' ') || value.includes('\\'));
+      const finalValue = needsQuotes ? `"${value}"` : value;
+      return `${acc} --${key} ${finalValue}`;
     }, '');
 
     if (env && env.length > 0) {
       env.forEach((e) => {
         let [key, value] = e.split('=');
-        const needsQuotes = '"' !== value[0] && value.includes(' ');
+        value = escapeShellValue(value);
+        const needsQuotes =
+          !value.startsWith('"') &&
+          (value.includes(' ') || value.includes('\\'));
         if (needsQuotes) value = `"${value}"`;
         paramsString += ` --env ${key}=${value}`;
       });

tsconfig.json

@@ -1,6 +1,7 @@
 {
   "compilerOptions": {
     "target": "es6",
+    "lib": ["es2016"],
     "module": "commonjs",
     "outDir": "./dist",
     "rootDir": ".",