Skip to content

Commit e5aeea1

Browse files
riglarclaude
andcommitted
Remove skip-chrome-onboarding feature and bump version to 2.0.0
This removes the skip-chrome-onboarding parameter from the action as it's no longer needed. Also updates the minimum Node.js version to 22.0.0 and bumps the package version to 2.0.0. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
1 parent 12be688 commit e5aeea1

File tree

6 files changed

+21
-33
lines changed

6 files changed

+21
-33
lines changed

README.md

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -332,18 +332,6 @@ For iOS tests, you can run your flows against x86 architecture simulators instea
332332
x86-arch: true
333333
```
334334

335-
# Skip Chrome Onboarding (Android)
336-
337-
For Android tests, you can skip Chrome browser onboarding screens when running tests:
338-
339-
```yaml
340-
- uses: devicecloud-dev/device-cloud-for-maestro@v1
341-
with:
342-
api-key: ${{ secrets.DCD_API_KEY }}
343-
app-file: app.apk
344-
skip-chrome-onboarding: true
345-
```
346-
347335
# Runner Types (Experimental)
348336

349337
You can specify a custom runner type using the `runner-type` parameter:
@@ -478,8 +466,7 @@ Here's a complete example showing all available options:
478466
orientation: 0 # 0|90|180|270 (Android only)
479467
google-play: false # Use Google Play devices (Android)
480468
x86-arch: false # Use x86 architecture (iOS)
481-
skip-chrome-onboarding: false # Skip Chrome onboarding screens (Android)
482-
469+
483470
# Flow Configuration
484471
flows: myFlows/ # or workspace: myFlows/ (flows takes precedence)
485472
exclude-flows: |

action.yml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ inputs:
8484
description: 'Runs Maestro with the --format flag, this will generate a report in the specified format <options: junit|html>'
8585
required: false
8686
retry:
87-
description: 'Number of times to retry the run if it fails (same as pressing retry in the UI, this will deduct credits from your account)'
87+
description: 'Number of times to retry the run if it fails (same as pressing retry in the UI, this is free)'
8888
required: false
8989
workspace:
9090
description: 'The path to the workspace folder containing your flows'
@@ -100,9 +100,6 @@ inputs:
100100
description: '[experimental] The type of runner to use <options: m1|m4> - note: anything other than default will incur premium pricing tiers. See https://docs.devicecloud.dev/reference/runner-type for more information'
101101
required: false
102102
default: 'default'
103-
skip-chrome-onboarding:
104-
description: '[Android only] Skip Chrome browser onboarding screens when running tests'
105-
required: false
106103
debug:
107104
description: 'Enable debug mode for more verbose output'
108105
required: false

dist/index.js

Lines changed: 17 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -29933,7 +29933,7 @@ Object.defineProperty(exports, "__esModule", ({ value: true }));
2993329933
const core_1 = __nccwpck_require__(2186);
2993429934
const params_1 = __nccwpck_require__(5966);
2993529935
const child_process_1 = __nccwpck_require__(2081);
29936-
const dcdVersionString = '@devicecloud.dev/dcd@>=3.7.4';
29936+
const dcdPackageName = '@devicecloud.dev/dcd';
2993729937
const escapeShellValue = (value) => {
2993829938
// Escape special characters that could cause shell interpretation issues
2993929939
return value.replace(/(["\\'$`!\s\[\]{}()&|;<>*?#^~])/g, '\\$1');
@@ -29965,7 +29965,7 @@ const executeCommand = (command, log = true) => {
2996529965
});
2996629966
});
2996729967
};
29968-
const getTestStatus = (uploadId, apiKey, apiUrl) => __awaiter(void 0, void 0, void 0, function* () {
29968+
const getTestStatus = (uploadId, apiKey, dcdVersionString, apiUrl) => __awaiter(void 0, void 0, void 0, function* () {
2996929969
try {
2997029970
let command = `npx --yes "${dcdVersionString}" status --json --upload-id ${uploadId} --api-key ${escapeShellValue(apiKey)}`;
2997129971
if (apiUrl) {
@@ -29979,10 +29979,23 @@ const getTestStatus = (uploadId, apiKey, apiUrl) => __awaiter(void 0, void 0, vo
2997929979
return null;
2998029980
}
2998129981
});
29982+
const getLatestDcdVersion = () => __awaiter(void 0, void 0, void 0, function* () {
29983+
try {
29984+
const { output } = yield executeCommand(`npm view ${dcdPackageName} version`, false);
29985+
const version = output.trim();
29986+
console.info(`Latest DCD version from npm: ${version}`);
29987+
return `${dcdPackageName}@${version}`;
29988+
}
29989+
catch (error) {
29990+
console.warn('Failed to fetch latest DCD version, falling back to >=4.0.3:', error);
29991+
return `${dcdPackageName}@>=4.0.3`;
29992+
}
29993+
});
2998229994
const run = () => __awaiter(void 0, void 0, void 0, function* () {
2998329995
var _a;
2998429996
try {
29985-
const { additionalAppBinaryIds, additionalAppFiles, androidApiLevel, androidDevice, apiKey, apiUrl, appBinaryId, appFilePath, async, config, deviceLocale, downloadArtifacts, env, excludeFlows, excludeTags, googlePlay, ignoreShaCheck, includeTags, iOSVersion, iosDevice, jsonFile, maestroVersion, name, orientation, report, retry, workspaceFolder, x86Arch, runnerType, skipChromeOnboarding, debug, moropoV1ApiKey, } = yield (0, params_1.getParameters)();
29997+
const dcdVersionString = yield getLatestDcdVersion();
29998+
const { additionalAppBinaryIds, additionalAppFiles, androidApiLevel, androidDevice, apiKey, apiUrl, appBinaryId, appFilePath, async, config, deviceLocale, downloadArtifacts, env, excludeFlows, excludeTags, googlePlay, ignoreShaCheck, includeTags, iOSVersion, iosDevice, jsonFile, maestroVersion, name, orientation, report, retry, workspaceFolder, x86Arch, runnerType, debug, moropoV1ApiKey, } = yield (0, params_1.getParameters)();
2998629999
const params = {
2998730000
'additional-app-binary-ids': additionalAppBinaryIds,
2998830001
'additional-app-files': additionalAppFiles,
@@ -30012,7 +30025,6 @@ const run = () => __awaiter(void 0, void 0, void 0, function* () {
3001230025
'x86-arch': x86Arch,
3001330026
'runner-type': runnerType,
3001430027
'json-file': jsonFile,
30015-
'skip-chrome-onboarding': skipChromeOnboarding,
3001630028
debug,
3001730029
'moropo-v1-api-key': moropoV1ApiKey,
3001830030
};
@@ -30053,7 +30065,7 @@ const run = () => __awaiter(void 0, void 0, void 0, function* () {
3005330065
throw new Error('Failed to get upload ID from console URL');
3005430066
}
3005530067
// Get the test status and results
30056-
const result = yield getTestStatus(uploadId, apiKey, apiUrl);
30068+
const result = yield getTestStatus(uploadId, apiKey, dcdVersionString, apiUrl);
3005730069
if (result) {
3005830070
// Set outputs based on the status results
3005930071
(0, core_1.setOutput)('DEVICE_CLOUD_CONSOLE_URL', result.consoleUrl || '');
@@ -30245,7 +30257,6 @@ function getParameters() {
3024530257
const config = core.getInput('config', { required: false });
3024630258
const runnerType = core.getInput('runner-type', { required: false });
3024730259
const jsonFile = core.getInput('json-file', { required: false }) === 'true';
30248-
const skipChromeOnboarding = core.getInput('skip-chrome-onboarding', { required: false }) === 'true';
3024930260
const debug = core.getInput('debug', { required: false }) === 'true';
3025030261
const moropoV1ApiKey = core.getInput('moropo-v1-api-key', {
3025130262
required: false,
@@ -30287,7 +30298,6 @@ function getParameters() {
3028730298
config,
3028830299
runnerType,
3028930300
jsonFile,
30290-
skipChromeOnboarding,
3029130301
debug,
3029230302
moropoV1ApiKey,
3029330303
};

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,11 @@
22
"name": "dcd-github-action",
33
"description": "run maestro tests on devicecloud.dev",
44
"author": "devicecloud.dev",
5-
"version": "1.3.13",
5+
"version": "2.0.0",
66
"main": "src/index.ts",
77
"license": "MIT",
88
"engines": {
9-
"node": ">=20.0.0"
9+
"node": ">=22.0.0"
1010
},
1111
"scripts": {
1212
"build": "ncc build",

src/index.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,6 @@ const run = async (): Promise<void> => {
127127
workspaceFolder,
128128
x86Arch,
129129
runnerType,
130-
skipChromeOnboarding,
131130
debug,
132131
moropoV1ApiKey,
133132
} = await getParameters();
@@ -161,7 +160,6 @@ const run = async (): Promise<void> => {
161160
'x86-arch': x86Arch,
162161
'runner-type': runnerType,
163162
'json-file': jsonFile,
164-
'skip-chrome-onboarding': skipChromeOnboarding,
165163
debug,
166164
'moropo-v1-api-key': moropoV1ApiKey,
167165
};

src/methods/params.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ export type Params = {
3131
config?: string;
3232
runnerType?: string;
3333
jsonFile?: boolean;
34-
skipChromeOnboarding?: boolean;
3534
debug?: boolean;
3635
moropoV1ApiKey?: string;
3736
};
@@ -180,8 +179,6 @@ export async function getParameters(): Promise<Params> {
180179
const config = core.getInput('config', { required: false });
181180
const runnerType = core.getInput('runner-type', { required: false });
182181
const jsonFile = core.getInput('json-file', { required: false }) === 'true';
183-
const skipChromeOnboarding =
184-
core.getInput('skip-chrome-onboarding', { required: false }) === 'true';
185182
const debug = core.getInput('debug', { required: false }) === 'true';
186183
const moropoV1ApiKey = core.getInput('moropo-v1-api-key', {
187184
required: false,
@@ -229,7 +226,6 @@ export async function getParameters(): Promise<Params> {
229226
config,
230227
runnerType,
231228
jsonFile,
232-
skipChromeOnboarding,
233229
debug,
234230
moropoV1ApiKey,
235231
};

0 commit comments

Comments
 (0)