Improve error messages with log output and full log path

Author: omnarayan

.github/workflows/release.yml

@@ -9,6 +9,8 @@ on:
 jobs:
   release:
     runs-on: macos-latest
+    permissions:
+      contents: write
     steps:
       - uses: actions/checkout@v4
 
@@ -39,10 +41,22 @@ jobs:
             maestro-jars.zip
             maestro-ios-runner.zip
 
+      - name: Get version
+        id: version
+        run: |
+          if [[ "${{ github.ref }}" == refs/tags/* ]]; then
+            echo "version=${GITHUB_REF#refs/tags/}" >> $GITHUB_OUTPUT
+          else
+            echo "version=v0.0.0-$(git rev-parse --short HEAD)" >> $GITHUB_OUTPUT
+          fi
+
       - name: Create release
-        if: startsWith(github.ref, 'refs/tags/')
         uses: softprops/action-gh-release@v1
         with:
+          tag_name: ${{ steps.version.outputs.version }}
+          name: ${{ steps.version.outputs.version }}
+          draft: false
+          prerelease: ${{ !startsWith(github.ref, 'refs/tags/') }}
           files: |
             dist/maestro-ios-device-darwin-amd64
             dist/maestro-ios-device-darwin-arm64

cmd/maestro-ios-device/main.go

@@ -109,7 +109,7 @@ func run() {
 
 	fmt.Println()
 	fmt.Println("✅ Ready! Run:")
-	fmt.Printf("   maestro --driver-host-port %d --device %s test <flow.yaml>\n\n", localPort, *deviceUDID)
+	fmt.Printf("   maestro --driver-host-port %d --device %s --app-file /path/to/app.ipa test flow.yaml\n\n", localPort, *deviceUDID)
 	fmt.Println("Press Ctrl+C to stop.")
 
 	<-sigChan

internal/runner/runner.go

@@ -70,7 +70,7 @@ func (r *Runner) Build(ctx context.Context) error {
 	fmt.Println("🔨 Building (up to 10 min)...")
 
 	if err := cmd.Run(); err != nil {
-		return fmt.Errorf("build failed (see %s)", logPath)
+		return fmt.Errorf("build failed:\n%s\n\nFull log: %s", tailLog(logPath, 20), logPath)
 	}
 
 	if _, err := r.findXctestrun(); err != nil {
@@ -122,7 +122,7 @@ func (r *Runner) Start(ctx context.Context) error {
 	fmt.Println("▶️  Starting runner...")
 
 	if err := r.cmd.Start(); err != nil {
-		return err
+		return fmt.Errorf("failed to start runner: %w", err)
 	}
 
 	if err := r.waitForStartup(logPath); err != nil {
@@ -166,7 +166,7 @@ func (r *Runner) waitForStartup(logPath string) error {
 				return err
 			}
 		case <-timeout:
-			return fmt.Errorf("startup timeout (see %s)", logPath)
+			return fmt.Errorf("startup timeout (90s):\n%s\n\nFull log: %s", tailLog(logPath, 20), logPath)
 		}
 	}
 }
@@ -185,7 +185,19 @@ func checkLog(log, logPath string) error {
 		return fmt.Errorf("certificate not trusted - trust it in Settings > General > VPN & Device Management")
 	}
 	if strings.Contains(log, "Testing failed:") {
-		return fmt.Errorf("runner failed (see %s)", logPath)
+		return fmt.Errorf("runner failed:\n%s\n\nFull log: %s", tailLog(logPath, 20), logPath)
 	}
 	return errNotReady
 }
+
+func tailLog(path string, lines int) string {
+	content, err := os.ReadFile(path)
+	if err != nil {
+		return fmt.Sprintf("(could not read log: %s)", err)
+	}
+	allLines := strings.Split(string(content), "\n")
+	if len(allLines) <= lines {
+		return string(content)
+	}
+	return strings.Join(allLines[len(allLines)-lines:], "\n")
+}

setup.sh

@@ -26,7 +26,7 @@ echo "╚═══════════════════════
 echo ""
 
 printf "Continue with installation? [y/N] "
-read -r REPLY
+read -r REPLY </dev/tty
 if [ "$REPLY" != "y" ] && [ "$REPLY" != "Y" ]; then
     echo "Installation cancelled."
     exit 1