Skip to content

Commit 5c0798d

Browse files
authored
Merge pull request #16 from devilbox/improve-docker
Fix: Allow variable export
2 parents 57ff4e6 + d323078 commit 5c0798d

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

Makefile.docker

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -198,17 +198,18 @@ docker-load:
198198
# -------------------------------------------------------------------------------------------------
199199
.PHONY: docker-pull-base-image
200200
_DOCKER_PULL_BASE_IMAGES_FOUND = $(shell grep FROM $(DIR)/$(FILE) | sed 's/^FROM\s*//g' | sed 's/\s.*$$//g' | sort -u )
201-
DOCKER_PULL_VARIABLES = VERSION=$(VERSION)
201+
DOCKER_PULL_VARIABLES = "VERSION=$(VERSION)"
202202
docker-pull-base-image:
203203
@echo "################################################################################"
204204
@echo "# Pulling Base Image (platform: $(ARCH))"
205205
@echo "################################################################################"
206206
@echo "Docker File: $(DIR)/$(FILE)"
207-
@if [ -n "$(DOCKER_PULL_VARIABLES)" ]; then for e in "$(DOCKER_PULL_VARIABLES)";do export "$${e}";done; fi; echo "Images Found: $(_DOCKER_PULL_BASE_IMAGES_FOUND)"
208-
@if [ -n "$(DOCKER_PULL_VARIABLES)" ]; then for e in "$(DOCKER_PULL_VARIABLES)";do export "$${e}";done; fi; echo "Images Ignore: $(DOCKER_PULL_BASE_IMAGES_IGNORE)"
207+
@echo "Var Exports: $(DOCKER_PULL_VARIABLES)"
208+
@if [ -n $(DOCKER_PULL_VARIABLES) ];then for e in $(DOCKER_PULL_VARIABLES);do export $${e};done;fi; echo "Images Found: $(_DOCKER_PULL_BASE_IMAGES_FOUND)"
209+
@if [ -n $(DOCKER_PULL_VARIABLES) ];then for e in $(DOCKER_PULL_VARIABLES);do export $${e};done;fi; echo "Images Ignore: $(DOCKER_PULL_BASE_IMAGES_IGNORE)"
209210
@echo
210211
@# These variables will be exported to the shell
211-
@if [ -n "$(DOCKER_PULL_VARIABLES)" ]; then for e in "$(DOCKER_PULL_VARIABLES)";do export "$${e}";done; fi; \
212+
@if [ -n $(DOCKER_PULL_VARIABLES) ];then for e in $(DOCKER_PULL_VARIABLES);do export $${e};done;fi; \
212213
echo $(_DOCKER_PULL_BASE_IMAGES_FOUND) | sed 's/\s/\n/g' | while read -r line; do \
213214
if echo "$(DOCKER_PULL_BASE_IMAGES_IGNORE)" | grep -F "$${line}" >/dev/null; then \
214215
continue; \

0 commit comments

Comments
 (0)