Skip to content

Commit 72d40dd

Browse files
authored
Merge pull request #14 from devilbox/improve-docker-pull
Be able to use variables
2 parents a805492 + 24538b8 commit 72d40dd

File tree

1 file changed

+4
-9
lines changed

1 file changed

+4
-9
lines changed

Makefile.docker

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -198,23 +198,18 @@ docker-load:
198198
# -------------------------------------------------------------------------------------------------
199199
.PHONY: docker-pull-base-image
200200
_DOCKER_PULL_BASE_IMAGES_FOUND = $(shell grep FROM $(DIR)/$(FILE) | sed 's/^FROM\s*//g' | sed 's/\s.*$$//g' | sort -u )
201-
_DOCKER_PULL_BASE_IMAGES_PULL = $(shell \
202-
for img in $$( echo "$(_DOCKER_PULL_BASE_IMAGES_FOUND)" | sed 's/\s/\n/g' ); do \
203-
if ! echo $(DOCKER_PULL_BASE_IMAGES_IGNORE) | grep -F "$${img}" >/dev/null; then \
204-
echo "$${img}"; \
205-
fi; \
206-
done; \
207-
)
208201
docker-pull-base-image:
209202
@echo "################################################################################"
210203
@echo "# Pulling Base Image (platform: $(ARCH))"
211204
@echo "################################################################################"
212205
@echo "Docker File: $(DIR)/$(FILE)"
213206
@echo "Images Found: $(_DOCKER_PULL_BASE_IMAGES_FOUND)"
214207
@echo "Images Ignore: $(DOCKER_PULL_BASE_IMAGES_IGNORE)"
215-
@echo "Images Actual: $(_DOCKER_PULL_BASE_IMAGES_PULL)"
216208
@echo
217-
@echo $(_DOCKER_PULL_BASE_IMAGES_PULL) | sed 's/\s/\n/g' | while read -r line; do \
209+
@echo $(_DOCKER_PULL_BASE_IMAGES_FOUND) | sed 's/\s/\n/g' | while read -r line; do \
210+
if echo "$(DOCKER_PULL_BASE_IMAGES_IGNORE)" | grep -F "$${line}" >/dev/null; then \
211+
continue; \
212+
fi; \
218213
echo "docker pull --platform $(ARCH) $${line}"; \
219214
SUCC=0; \
220215
for count in $$(seq 10); do \

0 commit comments

Comments
 (0)