Test using Java 25 compiler

devinrsmith · devinrsmith · commit 52b69d6124b7 · 2026-02-02T10:09:58.000-08:00
diff --git a/.github/workflows/build-ci.yml b/.github/workflows/build-ci.yml
@@ -20,14 +20,15 @@ jobs:
         with:
           distribution: 'temurin'
           java-version: |
+            25
             21
 
       - name: Setup Gradle
         uses: gradle/actions/setup-gradle@v5
 
       - name: Setup gradle properties
         run: |
-          .github/scripts/gradle-properties.sh 21 >> gradle.properties
+          .github/scripts/gradle-properties.sh 21 25 >> gradle.properties
           cat gradle.properties
 
       - name: Get Semver
@@ -145,14 +146,15 @@ jobs:
         with:
           distribution: 'temurin'
           java-version: |
+            25
             21
 
       - name: Setup Gradle
         uses: gradle/actions/setup-gradle@v5
 
       - name: Setup gradle properties
         run: |
-          .github/scripts/gradle-properties.sh 21 >> gradle.properties
+          .github/scripts/gradle-properties.sh 21 25 >> gradle.properties
           cat gradle.properties
 
       - name: Set up Docker Buildx
diff --git a/.github/workflows/check-ci.yml b/.github/workflows/check-ci.yml
@@ -53,14 +53,15 @@ jobs:
         with:
           distribution: 'temurin'
           java-version: |
+            25
             21
 
       - name: Setup Gradle
         uses: gradle/actions/setup-gradle@v5
 
       - name: Setup gradle properties
         run: |
-          .github/scripts/gradle-properties.sh 21 >> gradle.properties
+          .github/scripts/gradle-properties.sh 21 25 >> gradle.properties
           cat gradle.properties
 
       - name: Check
diff --git a/.github/workflows/dependency-submission.yml b/.github/workflows/dependency-submission.yml
@@ -19,11 +19,12 @@ jobs:
         with:
           distribution: 'temurin'
           java-version: |
+            25
             21
 
       - name: Setup gradle properties
         run: |
-          .github/scripts/gradle-properties.sh 21 >> gradle.properties
+          .github/scripts/gradle-properties.sh 21 25 >> gradle.properties
           cat gradle.properties
 
       - name: Generate and submit dependency graph
diff --git a/.github/workflows/docs-ci.yml b/.github/workflows/docs-ci.yml
@@ -133,14 +133,15 @@ jobs:
         with:
           distribution: 'temurin'
           java-version: |
+            25
             21
 
       - name: Setup Gradle
         uses: gradle/actions/setup-gradle@v5
 
       - name: Setup gradle properties
         run: |
-          .github/scripts/gradle-properties.sh 21 >> gradle.properties
+          .github/scripts/gradle-properties.sh 21 25 >> gradle.properties
           cat gradle.properties
 
       - name: All Javadoc
@@ -185,14 +186,15 @@ jobs:
         with:
           distribution: 'temurin'
           java-version: |
+            25
             21
 
       - name: Setup Gradle
         uses: gradle/actions/setup-gradle@v5
 
       - name: Setup gradle properties
         run: |
-          .github/scripts/gradle-properties.sh 21 >> gradle.properties
+          .github/scripts/gradle-properties.sh 21 25 >> gradle.properties
           cat gradle.properties
 
       - name: Run typedoc on JS API
@@ -237,14 +239,15 @@ jobs:
         with:
           distribution: 'temurin'
           java-version: |
+            25
             21
 
       - name: Setup Gradle
         uses: gradle/actions/setup-gradle@v5
 
       - name: Setup gradle properties
         run: |
-          .github/scripts/gradle-properties.sh 21 >> gradle.properties
+          .github/scripts/gradle-properties.sh 21 25 >> gradle.properties
           cat gradle.properties
 
       - name: Generate Python Docs
@@ -316,14 +319,15 @@ jobs:
         with:
           distribution: 'temurin'
           java-version: |
+            25
             21
 
       - name: Setup Gradle
         uses: gradle/actions/setup-gradle@v5
 
       - name: Setup gradle properties
         run: |
-          .github/scripts/gradle-properties.sh 21 >> gradle.properties
+          .github/scripts/gradle-properties.sh 21 25 >> gradle.properties
           cat gradle.properties
 
       - name: Generate C++ Docs
@@ -387,14 +391,15 @@ jobs:
         with:
           distribution: 'temurin'
           java-version: |
+            25
             21
 
       - name: Setup Gradle
         uses: gradle/actions/setup-gradle@v5
 
       - name: Setup gradle properties
         run: |
-          .github/scripts/gradle-properties.sh 21 >> gradle.properties
+          .github/scripts/gradle-properties.sh 21 25 >> gradle.properties
           cat gradle.properties
 
       - name: Generate R Docs
@@ -442,14 +447,15 @@ jobs:
         with:
           distribution: 'temurin'
           java-version: |
+            25
             21
 
       - name: Setup Gradle
         uses: gradle/actions/setup-gradle@v5
 
       - name: Setup gradle properties
         run: |
-          .github/scripts/gradle-properties.sh 21 >> gradle.properties
+          .github/scripts/gradle-properties.sh 21 25 >> gradle.properties
           cat gradle.properties
 
       - name: Generate Protobuf Docs
diff --git a/.github/workflows/nightly-check-ci.yml b/.github/workflows/nightly-check-ci.yml
@@ -162,14 +162,15 @@ jobs:
         with:
           distribution: 'temurin'
           java-version: |
+            25
             21
 
       - name: Setup Gradle
         uses: gradle/actions/setup-gradle@v5
 
       - name: Setup gradle properties
         run: |
-          .github/scripts/gradle-properties.sh 21 >> gradle.properties
+          .github/scripts/gradle-properties.sh 21 25 >> gradle.properties
           cat gradle.properties
           
       - name: Run gradle ${{ matrix.gradle-task }}
diff --git a/.github/workflows/nightly-image-check.yml b/.github/workflows/nightly-image-check.yml
@@ -18,14 +18,15 @@ jobs:
         with:
           distribution: 'temurin'
           java-version: |
+            25
             21
 
       - name: Setup Gradle
         uses: gradle/actions/setup-gradle@v5
 
       - name: Setup gradle properties
         run: |
-          .github/scripts/gradle-properties.sh 21 >> gradle.properties
+          .github/scripts/gradle-properties.sh 21 25 >> gradle.properties
           cat gradle.properties
 
       - name: Run gradle
diff --git a/.github/workflows/nightly-publish-ci.yml b/.github/workflows/nightly-publish-ci.yml
@@ -24,14 +24,15 @@ jobs:
         with:
           distribution: 'temurin'
           java-version: |
+            25
             21
 
       - name: Setup Gradle
         uses: gradle/actions/setup-gradle@v5
 
       - name: Setup gradle properties
         run: |
-          .github/scripts/gradle-properties.sh 21 >> gradle.properties
+          .github/scripts/gradle-properties.sh 21 25 >> gradle.properties
           cat gradle.properties
 
       - name: Publish to Central Portal snapshots repository
diff --git a/.github/workflows/publish-ci.yml b/.github/workflows/publish-ci.yml
@@ -53,14 +53,15 @@ jobs:
         with:
           distribution: 'temurin'
           java-version: |
+            25
             21
 
       - name: Setup Gradle
         uses: gradle/actions/setup-gradle@v5
 
       - name: Setup gradle properties
         run: |
-          .github/scripts/gradle-properties.sh 21 >> gradle.properties
+          .github/scripts/gradle-properties.sh 21 25 >> gradle.properties
           cat gradle.properties
 
       - name: Setup Node for deployment to npmjs
diff --git a/.github/workflows/quick-ci.yml b/.github/workflows/quick-ci.yml
@@ -44,14 +44,15 @@ jobs:
         with:
           distribution: 'temurin'
           java-version: |
+            25
             21
 
       - name: Setup Gradle
         uses: gradle/actions/setup-gradle@v5
 
       - name: Setup gradle properties
         run: |
-          .github/scripts/gradle-properties.sh 21 >> gradle.properties
+          .github/scripts/gradle-properties.sh 21 25 >> gradle.properties
           cat gradle.properties
 
       - name: Quick Task
diff --git a/.github/workflows/tag-base-images.yml b/.github/workflows/tag-base-images.yml
@@ -20,6 +20,7 @@ jobs:
         with:
           distribution: 'temurin'
           java-version: |
+            25
             21
 
       - name: Setup Gradle
@@ -31,7 +32,7 @@ jobs:
 
       - name: Setup gradle properties
         run: |
-          .github/scripts/gradle-properties.sh 21 >> gradle.properties
+          .github/scripts/gradle-properties.sh 21 25 >> gradle.properties
           cat gradle.properties
 
       - name: Login to ghcr.io
diff --git a/buildSrc/build.gradle b/buildSrc/build.gradle
@@ -7,6 +7,7 @@ plugins {
 // We choose to use Java 21 as the buildSrc toolchain / compiler (same as the normal projects); and set a target language
 // level of Java 17. The target language level here does not effect the target language level of the normal projects.
 
+// Note: holding this back to 21 instead of 25 b/c of reasons?
 final int buildSrcCompilerVersion = 21
 final int buildSrcLanguageLevel = 17
 
diff --git a/buildSrc/src/main/groovy/io.deephaven.java-toolchain-conventions.gradle b/buildSrc/src/main/groovy/io.deephaven.java-toolchain-conventions.gradle
@@ -11,8 +11,8 @@ plugins {
 // In particular, we would like deephaven-core to be buildable with minimal Java prerequisites - ideally, the default
 // build should only require the default toolchain (compilerVersion / compilerVendor).
 //
-// Note: if / when compilerVersion default is changed from 21, we should match that in version in buildSrc/build.gradle.
-def compilerVersion = Integer.parseInt((String)project.findProperty('compilerVersion') ?: '21')
+// Note: if / when compilerVersion default is changed from 25, we should match that in version in buildSrc/build.gradle.
+def compilerVersion = Integer.parseInt((String)project.findProperty('compilerVersion') ?: '25')
 def compilerVendor = project.hasProperty('compilerVendor') ?  JvmVendorSpec.matching((String)project.property('compilerVendor')): null
 
 def languageLevel = Integer.parseInt((String)project.findProperty('languageLevel') ?: '11')
diff --git a/extensions/parquet/table/build.gradle b/extensions/parquet/table/build.gradle
@@ -37,7 +37,9 @@ dependencies {
     implementation project(':codec-builtin')
     implementation project(':codec-cache')
 
-    implementation libs.commons.lang3
+    api (libs.commons.lang3) {
+        because 'org.apache.commons.lang3.mutable.MutableObject is exposed in public API of ParquetTools'
+    }
     implementation libs.commons.text
     implementation libs.commons.compress
 
