Skip to content

Commit 3d15777

Browse files
devinslickdevinslick
committed
Fix mstats errors: add metric_name filter and inline macros
1 parent fa2942d commit 3d15777

File tree

2 files changed

+104
-8
lines changed

2 files changed

+104
-8
lines changed

‎default/data/ui/views/caca_admin.xml‎

Lines changed: 103 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,23 @@
107107
<title>Filtered Dashboard Count</title>
108108
<single>
109109
<search>
110-
<query>`get_all_dashboards_summary`
110+
<query>| mstats sum(_value) as metric_value WHERE index=caca_metrics AND metric_name="dashboard.*" BY pretty_name, metric_name, app span=1d
111+
| where _time >= relative_time(now(), "-7d")
112+
| stats sum(metric_value) as total_value by pretty_name, metric_name, app
113+
| eval metric_type=case(
114+
metric_name=="dashboard.views", "views_7d",
115+
metric_name=="dashboard.edits", "edits_7d",
116+
metric_name=="dashboard.errors", "errors_7d",
117+
metric_name=="dashboard.load_time", "load_time_7d",
118+
1=1, "other")
119+
| eval {metric_type}=total_value
120+
| stats values(app) as app sum(views_7d) as views_7d sum(edits_7d) as edits_7d sum(errors_7d) as errors_7d avg(load_time_7d) as avg_load_time_7d by pretty_name
121+
| fillnull value=0 views_7d edits_7d errors_7d avg_load_time_7d
122+
| eval health_status=case(
123+
errors_7d > 10, "critical",
124+
errors_7d > 0, "warning",
125+
views_7d == 0, "stale",
126+
1=1, "healthy")
111127
| lookup dashboard_registry pretty_name OUTPUT owner sharing description dashboard_uri
112128
| search pretty_name="$name_filter$" $app_filter$ $owner_filter$ $sharing_filter$ $health_filter$
113129
| eval perf_category=case(
@@ -132,7 +148,23 @@
132148
<title>Total Views (Filtered)</title>
133149
<single>
134150
<search>
135-
<query>`get_all_dashboards_summary`
151+
<query>| mstats sum(_value) as metric_value WHERE index=caca_metrics AND metric_name="dashboard.*" BY pretty_name, metric_name, app span=1d
152+
| where _time >= relative_time(now(), "-7d")
153+
| stats sum(metric_value) as total_value by pretty_name, metric_name, app
154+
| eval metric_type=case(
155+
metric_name=="dashboard.views", "views_7d",
156+
metric_name=="dashboard.edits", "edits_7d",
157+
metric_name=="dashboard.errors", "errors_7d",
158+
metric_name=="dashboard.load_time", "load_time_7d",
159+
1=1, "other")
160+
| eval {metric_type}=total_value
161+
| stats values(app) as app sum(views_7d) as views_7d sum(edits_7d) as edits_7d sum(errors_7d) as errors_7d avg(load_time_7d) as avg_load_time_7d by pretty_name
162+
| fillnull value=0 views_7d edits_7d errors_7d avg_load_time_7d
163+
| eval health_status=case(
164+
errors_7d > 10, "critical",
165+
errors_7d > 0, "warning",
166+
views_7d == 0, "stale",
167+
1=1, "healthy")
136168
| lookup dashboard_registry pretty_name OUTPUT owner sharing description dashboard_uri
137169
| search pretty_name="$name_filter$" $app_filter$ $owner_filter$ $sharing_filter$ $health_filter$
138170
| eval perf_category=case(
@@ -158,7 +190,23 @@
158190
<title>Health Issues</title>
159191
<single>
160192
<search>
161-
<query>`get_all_dashboards_summary`
193+
<query>| mstats sum(_value) as metric_value WHERE index=caca_metrics AND metric_name="dashboard.*" BY pretty_name, metric_name, app span=1d
194+
| where _time >= relative_time(now(), "-7d")
195+
| stats sum(metric_value) as total_value by pretty_name, metric_name, app
196+
| eval metric_type=case(
197+
metric_name=="dashboard.views", "views_7d",
198+
metric_name=="dashboard.edits", "edits_7d",
199+
metric_name=="dashboard.errors", "errors_7d",
200+
metric_name=="dashboard.load_time", "load_time_7d",
201+
1=1, "other")
202+
| eval {metric_type}=total_value
203+
| stats values(app) as app sum(views_7d) as views_7d sum(edits_7d) as edits_7d sum(errors_7d) as errors_7d avg(load_time_7d) as avg_load_time_7d by pretty_name
204+
| fillnull value=0 views_7d edits_7d errors_7d avg_load_time_7d
205+
| eval health_status=case(
206+
errors_7d > 10, "critical",
207+
errors_7d > 0, "warning",
208+
views_7d == 0, "stale",
209+
1=1, "healthy")
162210
| lookup dashboard_registry pretty_name OUTPUT owner sharing description dashboard_uri
163211
| search pretty_name="$name_filter$" $app_filter$ $owner_filter$ $sharing_filter$ $health_filter$
164212
| eval perf_category=case(
@@ -185,7 +233,23 @@
185233
<title>Performance Issues</title>
186234
<single>
187235
<search>
188-
<query>`get_all_dashboards_summary`
236+
<query>| mstats sum(_value) as metric_value WHERE index=caca_metrics AND metric_name="dashboard.*" BY pretty_name, metric_name, app span=1d
237+
| where _time >= relative_time(now(), "-7d")
238+
| stats sum(metric_value) as total_value by pretty_name, metric_name, app
239+
| eval metric_type=case(
240+
metric_name=="dashboard.views", "views_7d",
241+
metric_name=="dashboard.edits", "edits_7d",
242+
metric_name=="dashboard.errors", "errors_7d",
243+
metric_name=="dashboard.load_time", "load_time_7d",
244+
1=1, "other")
245+
| eval {metric_type}=total_value
246+
| stats values(app) as app sum(views_7d) as views_7d sum(edits_7d) as edits_7d sum(errors_7d) as errors_7d avg(load_time_7d) as avg_load_time_7d by pretty_name
247+
| fillnull value=0 views_7d edits_7d errors_7d avg_load_time_7d
248+
| eval health_status=case(
249+
errors_7d > 10, "critical",
250+
errors_7d > 0, "warning",
251+
views_7d == 0, "stale",
252+
1=1, "healthy")
189253
| lookup dashboard_registry pretty_name OUTPUT owner sharing description dashboard_uri
190254
| search pretty_name="$name_filter$" $app_filter$ $owner_filter$ $sharing_filter$ $health_filter$
191255
| eval perf_category=case(
@@ -236,7 +300,23 @@
236300
<title>Dashboard Management List</title>
237301
<table>
238302
<search>
239-
<query>`get_all_dashboards_summary`
303+
<query>| mstats sum(_value) as metric_value WHERE index=caca_metrics AND metric_name="dashboard.*" BY pretty_name, metric_name, app span=1d
304+
| where _time >= relative_time(now(), "-7d")
305+
| stats sum(metric_value) as total_value by pretty_name, metric_name, app
306+
| eval metric_type=case(
307+
metric_name=="dashboard.views", "views_7d",
308+
metric_name=="dashboard.edits", "edits_7d",
309+
metric_name=="dashboard.errors", "errors_7d",
310+
metric_name=="dashboard.load_time", "load_time_7d",
311+
1=1, "other")
312+
| eval {metric_type}=total_value
313+
| stats values(app) as app sum(views_7d) as views_7d sum(edits_7d) as edits_7d sum(errors_7d) as errors_7d avg(load_time_7d) as avg_load_time_7d by pretty_name
314+
| fillnull value=0 views_7d edits_7d errors_7d avg_load_time_7d
315+
| eval health_status=case(
316+
errors_7d > 10, "critical",
317+
errors_7d > 0, "warning",
318+
views_7d == 0, "stale",
319+
1=1, "healthy")
240320
| lookup dashboard_registry pretty_name OUTPUT owner sharing description dashboard_uri
241321
| search pretty_name="$name_filter$" $app_filter$ $owner_filter$ $sharing_filter$ $health_filter$
242322
| eval perf_category=case(
@@ -265,7 +345,7 @@
265345
sharing=="user", "🔒 Private",
266346
1=1, coalesce(sharing, "-"))
267347
| join type=left pretty_name
268-
[search `comment("Get load time metrics if they exist")` | mstats avg(_value) as avg_total_load_time WHERE index=caca_metrics metric_name="dashboard.load_time" BY pretty_name span=1h
348+
[| mstats avg(_value) as avg_total_load_time WHERE index=caca_metrics AND metric_name="dashboard.load_time" BY pretty_name span=1h
269349
| where _time &gt;= relative_time(now(), "$load_time_period$")
270350
| stats avg(avg_total_load_time) as avg_total_load_time by pretty_name
271351
| eval avg_total_load_time=round(avg_total_load_time, 0)]
@@ -392,7 +472,23 @@
392472
<title>🎯 Recommended Bulk Actions Based on Current Data</title>
393473
<table>
394474
<search>
395-
<query>`get_all_dashboards_summary`
475+
<query>| mstats sum(_value) as metric_value WHERE index=caca_metrics AND metric_name="dashboard.*" BY pretty_name, metric_name, app span=1d
476+
| where _time >= relative_time(now(), "-7d")
477+
| stats sum(metric_value) as total_value by pretty_name, metric_name, app
478+
| eval metric_type=case(
479+
metric_name=="dashboard.views", "views_7d",
480+
metric_name=="dashboard.edits", "edits_7d",
481+
metric_name=="dashboard.errors", "errors_7d",
482+
metric_name=="dashboard.load_time", "load_time_7d",
483+
1=1, "other")
484+
| eval {metric_type}=total_value
485+
| stats values(app) as app sum(views_7d) as views_7d sum(edits_7d) as edits_7d sum(errors_7d) as errors_7d avg(load_time_7d) as avg_load_time_7d by pretty_name
486+
| fillnull value=0 views_7d edits_7d errors_7d avg_load_time_7d
487+
| eval health_status=case(
488+
errors_7d > 10, "critical",
489+
errors_7d > 0, "warning",
490+
views_7d == 0, "stale",
491+
1=1, "healthy")
396492
| lookup dashboard_registry pretty_name OUTPUT owner sharing description dashboard_uri
397493
| eval avg_load_time_7d=round(avg_load_time_7d, 0)
398494
| eval recommendation=case(

‎default/data/ui/views/poop_deck.xml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -341,7 +341,7 @@
341341
<title>😴 The Neglected - Low Engagement Dashboards (Active but Underused)</title>
342342
<table>
343343
<search>
344-
<query>| mstats sum(_value) as metric_value WHERE index=caca_metrics BY pretty_name, metric_name, app span=1d
344+
<query>| mstats sum(_value) as metric_value WHERE index=caca_metrics AND metric_name="dashboard.*" BY pretty_name, metric_name, app span=1d
345345
| where _time >= relative_time(now(), "-30d")
346346
| stats sum(metric_value) as total by pretty_name, metric_name, app
347347
| eval metric_type=case(

0 commit comments

Comments
 (0)