Skip to content

Commit fa6a04d

Browse files
Copilotdevinslick
andcommitted
Fix XML escaping for comparison operators in dashboard queries
Co-authored-by: devinslick <[email protected]>
1 parent 2cf43ce commit fa6a04d

File tree

2 files changed

+18
-18
lines changed

2 files changed

+18
-18
lines changed

default/data/ui/views/dashboard_leaderboard.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -115,9 +115,9 @@
115115
| eval avg_load_time_7d=round(avg_load_time_7d, 0)
116116
| eval perf_rating=case(
117117
avg_load_time_7d == 0, "-",
118-
avg_load_time_7d < 1000, "⚡ Fast",
119-
avg_load_time_7d < 3000, "✓ Good",
120-
avg_load_time_7d < 5000, "⚠ Slow",
118+
avg_load_time_7d &lt; 1000, "⚡ Fast",
119+
avg_load_time_7d &lt; 3000, "✓ Good",
120+
avg_load_time_7d &lt; 5000, "⚠ Slow",
121121
1=1, "✗ Very Slow")
122122
| eval health_badge=case(
123123
health_status=="healthy", "✓ Healthy",

default/data/ui/views/poop_deck.xml

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@
8989
<query>| mstats avg(avg_load_time) as avg_load WHERE index=caca_metrics AND metric_name="dashboard.load_time" BY pretty_name span=1d
9090
| where _time >= relative_time(now(), "-7d")
9191
| stats avg(avg_load) as avg_load_time by pretty_name
92-
| where avg_load_time > 5000
92+
| where avg_load_time &gt; 5000
9393
| stats count as slow_count</query>
9494
<earliest>-7d@d</earliest>
9595
<latest>now</latest>
@@ -144,7 +144,7 @@
144144
| sort -engagement_score
145145
| head 20
146146
| lookup dashboard_registry pretty_name OUTPUT owner description
147-
| eval health=case(errors_30d==0, "✓", errors_30d<5, "", 1=1, "")
147+
| eval health=case(errors_30d==0, "✓", errors_30d&lt;5, "⚠", 1=1, "✗")
148148
| table pretty_name app views_30d edits_30d errors_30d engagement_score health owner description
149149
| rename pretty_name as "Dashboard", app as "App", views_30d as "Views (30d)", edits_30d as "Edits (30d)", errors_30d as "Errors (30d)", engagement_score as "Score", health as "Health", owner as "Owner", description as "Description"</query>
150150
<earliest>-30d@d</earliest>
@@ -288,7 +288,7 @@
288288
<query>| mstats avg(avg_load_time) as avg_load, max(max_load_time) as max_load WHERE index=caca_metrics AND metric_name="dashboard.load_time" BY pretty_name, app span=1d
289289
| where _time >= relative_time(now(), "-7d")
290290
| stats avg(avg_load) as avg_load_time, max(max_load) as max_load_time by pretty_name, app
291-
| where avg_load_time > 3000
291+
| where avg_load_time &gt; 3000
292292
| eval avg_load_time=round(avg_load_time, 0)
293293
| eval max_load_time=round(max_load_time, 0)
294294
| lookup dashboard_registry pretty_name OUTPUT owner description
@@ -298,19 +298,19 @@
298298
| stats sum(views) as views_7d by pretty_name]
299299
| fillnull value=0 views_7d
300300
| eval performance_level=case(
301-
avg_load_time > 10000, "🔥 Critical",
302-
avg_load_time > 7000, "❌ Very Slow",
303-
avg_load_time > 5000, "⚠️ Slow",
301+
avg_load_time &gt; 10000, "🔥 Critical",
302+
avg_load_time &gt; 7000, "❌ Very Slow",
303+
avg_load_time &gt; 5000, "⚠️ Slow",
304304
1=1, "😐 Sluggish")
305305
| eval user_impact=case(
306-
views_7d > 100 AND avg_load_time > 5000, "HIGH - Poor user experience",
307-
views_7d > 10 AND avg_load_time > 5000, "MEDIUM - Affecting users",
308-
avg_load_time > 10000, "HIGH - Unacceptably slow",
306+
views_7d &gt; 100 AND avg_load_time &gt; 5000, "HIGH - Poor user experience",
307+
views_7d &gt; 10 AND avg_load_time &gt; 5000, "MEDIUM - Affecting users",
308+
avg_load_time &gt; 10000, "HIGH - Unacceptably slow",
309309
1=1, "LOW - Limited impact")
310310
| eval recommendation=case(
311-
avg_load_time > 10000, "URGENT: Optimize or disable",
312-
avg_load_time > 7000, "High priority optimization",
313-
avg_load_time > 5000, "Should optimize",
311+
avg_load_time &gt; 10000, "URGENT: Optimize or disable",
312+
avg_load_time &gt; 7000, "High priority optimization",
313+
avg_load_time &gt; 5000, "Should optimize",
314314
1=1, "Consider optimization")
315315
| table pretty_name app avg_load_time max_load_time views_7d performance_level user_impact recommendation owner description
316316
| rename pretty_name as "Dashboard", app as "App", avg_load_time as "Avg Load (ms)", max_load_time as "Max Load (ms)", views_7d as "Views (7d)", performance_level as "Performance", user_impact as "Impact", recommendation as "Recommendation", owner as "Owner", description as "Description"
@@ -358,15 +358,15 @@
358358
| eval {metric_type}=total
359359
| stats values(app) as app sum(views) as views_30d sum(edits) as edits_30d by pretty_name
360360
| fillnull value=0 views_30d edits_30d
361-
| where views_30d > 0 AND views_30d < 20
361+
| where views_30d > 0 AND views_30d &lt; 20
362362
| lookup dashboard_registry pretty_name OUTPUT owner description
363363
| join type=left pretty_name
364364
[| mstats latest(_value) as last_view WHERE index=caca_metrics AND metric_name="dashboard.views" BY pretty_name
365365
| eval last_viewed=strftime(_time, "%Y-%m-%d")]
366366
| eval avg_views_per_day=round(views_30d/30, 1)
367367
| eval status=case(
368-
views_30d < 5, "😴 Barely Used",
369-
views_30d < 10, "🥱 Rarely Used",
368+
views_30d &lt; 5, "😴 Barely Used",
369+
views_30d &lt; 10, "🥱 Rarely Used",
370370
1=1, "😐 Occasionally Used")
371371
| table pretty_name app views_30d avg_views_per_day edits_30d last_viewed status owner description
372372
| rename pretty_name as "Dashboard", app as "App", views_30d as "Views (30d)", avg_views_per_day as "Avg/Day", edits_30d as "Edits (30d)", last_viewed as "Last Viewed", status as "Status", owner as "Owner", description as "Description"

0 commit comments

Comments
 (0)