Skip to content

Commit 2f46ae2

Browse files
committed
docker: FROM_IMAGE -> base
1 parent 4432d8d commit 2f46ae2

File tree

6 files changed

+20
-20
lines changed

6 files changed

+20
-20
lines changed

.github/workflows/docker-bases.yml

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ jobs:
8484
push: true
8585
build-args: |
8686
gcc=${{ matrix.gcc }}
87-
${{ matrix.disable-gil && 'FROM_IMAGE=ubuntu-nogil' || '' }}
87+
${{ matrix.disable-gil && 'base=ubuntu-nogil' || '' }}
8888
tags: "devitocodes/bases:cpu-gcc${{ matrix.gcc }}${{ matrix.disable-gil && '-nogil' || '' }}"
8989

9090

@@ -138,7 +138,7 @@ jobs:
138138
target: "icx"
139139
build-args: |
140140
arch=icx
141-
${{ matrix.disable-gil && 'FROM_IMAGE=ubuntu-nogil' || '' }}
141+
${{ matrix.disable-gil && 'base=ubuntu-nogil' || '' }}
142142
tags: "devitocodes/bases:cpu-icx${{ matrix.disable-gil && '-nogil' || '' }}"
143143

144144
- name: SYCL CPU image
@@ -150,7 +150,7 @@ jobs:
150150
target: "cpu-sycl"
151151
build-args: |
152152
arch=cpu-sycl
153-
${{ matrix.disable-gil && 'FROM_IMAGE=ubuntu-nogil' || '' }}
153+
${{ matrix.disable-gil && 'base=ubuntu-nogil' || '' }}
154154
tags: "devitocodes/bases:cpu-sycl${{ matrix.disable-gil && '-nogil' || '' }}"
155155

156156
- name: SYCL GPU image
@@ -162,7 +162,7 @@ jobs:
162162
target: "gpu-sycl"
163163
build-args: |
164164
arch=gpu-sycl
165-
${{ matrix.disable-gil && 'FROM_IMAGE=ubuntu-nogil' || '' }}
165+
${{ matrix.disable-gil && 'base=ubuntu-nogil' || '' }}
166166
tags: "devitocodes/bases:gpu-sycl${{ matrix.disable-gil && '-nogil' || '' }}"
167167

168168
#######################################################
@@ -215,7 +215,7 @@ jobs:
215215
target: "nvc"
216216
build-args: |
217217
arch=nvc
218-
${{ matrix.disable-gil && 'FROM_IMAGE=ubuntu-nogil' || '' }}
218+
${{ matrix.disable-gil && 'base=ubuntu-nogil' || '' }}
219219
# Label (not tag) with runner name for traceability without changing image tags
220220
labels: builder-runner=${{ runner.name }}
221221
tags: "devitocodes/bases:nvidia-nvc${{ matrix.disable-gil && '-nogil' || '' }}"
@@ -229,7 +229,7 @@ jobs:
229229
target: "nvcc"
230230
build-args: |
231231
arch=nvcc
232-
${{ matrix.disable-gil && 'FROM_IMAGE=ubuntu-nogil' || '' }}
232+
${{ matrix.disable-gil && 'base=ubuntu-nogil' || '' }}
233233
labels: builder-runner=${{ runner.name }}
234234
tags: "devitocodes/bases:nvidia-nvcc${{ matrix.disable-gil && '-nogil' || '' }}"
235235

@@ -242,7 +242,7 @@ jobs:
242242
target: "nvc-host"
243243
build-args: |
244244
arch=nvc-host
245-
${{ matrix.disable-gil && 'FROM_IMAGE=ubuntu-nogil' || '' }}
245+
${{ matrix.disable-gil && 'base=ubuntu-nogil' || '' }}
246246
labels: builder-runner=${{ runner.name }}
247247
tags: "devitocodes/bases:cpu-nvc${{ matrix.disable-gil && '-nogil' || '' }}"
248248

@@ -298,7 +298,7 @@ jobs:
298298
ROCM_VERSION=5.5.1
299299
UCX_BRANCH=v1.13.1
300300
OMPI_BRANCH=v4.1.4
301-
${{ matrix.disable-gil && 'FROM_IMAGE=ubuntu-nogil' || '' }}
301+
${{ matrix.disable-gil && 'base=ubuntu-nogil' || '' }}
302302
tags: devitocodes/bases:amd${{ matrix.disable-gil && '-nogil' || '' }}
303303

304304
- name: AMD HIP image
@@ -310,5 +310,5 @@ jobs:
310310
target: "hip"
311311
build-args: |
312312
ROCM_VERSION=6.3.4
313-
${{ matrix.disable-gil && 'FROM_IMAGE=ubuntu-nogil' || '' }}
313+
${{ matrix.disable-gil && 'base=ubuntu-nogil' || '' }}
314314
tags: devitocodes/bases:amd-hip${{ matrix.disable-gil && '-nogil' || '' }}

docker/Dockerfile.amd

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,10 @@
44
##############################################################
55

66
ARG ROCM_VERSION=6.3.2
7-
ARG FROM_IMAGE=ubuntu:22.04
7+
ARG base=ubuntu:22.04
88

9-
# FROM_IMAGE may be specified with the nogil base to provide a Python build
10-
FROM $FROM_IMAGE AS ubuntu-base
9+
# Base may be specified with the nogil base to provide a Python build
10+
FROM $base AS ubuntu-base
1111
FROM rocm/dev-ubuntu-22.04:${ROCM_VERSION}-complete AS sdk-base
1212

1313
ENV DEBIAN_FRONTEND=noninteractive

docker/Dockerfile.cpu

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,10 @@
55
##############################################################
66

77
# Base image is either ubuntu or the nogil base
8-
ARG FROM_IMAGE=ubuntu:22.04
8+
ARG base=ubuntu:22.04
99
ARG gcc=""
1010

11-
FROM $FROM_IMAGE AS base
11+
FROM $base AS base
1212

1313
ENV DEBIAN_FRONTEND=noninteractive
1414

docker/Dockerfile.intel

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44
##############################################################
55

66
# Base image
7-
ARG FROM_IMAGE=ubuntu:22.04
8-
FROM $FROM_IMAGE as base
7+
ARG base=ubuntu:22.04
8+
FROM $base as base
99

1010
ENV DEBIAN_FRONTEND noninteractive
1111

docker/Dockerfile.nogil

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22
# Builds a base image with free-threaded Python 3.13
33
##############################################################
44

5-
ARG FROM_IMAGE=ubuntu:22.04
5+
ARG base=ubuntu:22.04
66

7-
FROM $FROM_IMAGE AS builder
7+
FROM $base AS builder
88

99
ENV DEBIAN_FRONTEND=noninteractive
1010

docker/Dockerfile.nvidia

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ ARG arch="nvc"
77
########################################################################
88
# Build base image with apt setup and common env
99
########################################################################
10-
ARG FROM_IMAGE=ubuntu:22.04
11-
FROM $FROM_IMAGE AS sdk-base
10+
ARG base=ubuntu:22.04
11+
FROM $base AS sdk-base
1212

1313
SHELL ["/bin/bash", "-c"]
1414

0 commit comments

Comments
 (0)